adding docs for shard_stores api #10124
Conversation
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
AntonEliatra
requested review from
kolchfa-aws,
Naarcha-AWS,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Anton Rubin <anton.rubin@eliatra.com>
|
@kolchfa-aws Thats ready for review now |
There was a problem hiding this comment.
Thank you, @AntonEliatra! Please see my comments and let me know if you have any questions.
Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
kolchfa-aws
added
5 - Editorial review
There was a problem hiding this comment.
@AntonEliatra Please see my comments and changes and let me know if you have any questions. Thanks!
Co-authored-by: Nathan Bower <nbower@amazon.com> Signed-off-by: AntonEliatra <anton.rubin@eliatra.com>
|
@natebower @kolchfa-aws that's now updated, perhaps better to wait for the API spec PR to get merged before merging this one |
natebower
added
6 - Done but waiting to merge
Description
adding docs for shard_stores api
Issues Resolved
Closes #2102
Version
all
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.