-
Notifications
You must be signed in to change notification settings - Fork 14
Refactor form navigation to left panel #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor form navigation to left panel #724
Conversation
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
… resp processors Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
… params; Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Thanks for taking a look. As a reminder, this is to get the bulk of the functionality into the feature branch. The final styling/wording/spacing etc is not finalized yet.
It greatly depends on what the error is. If it is an error creating, it will stay in not created state. If it is an error running ingest, it will still be active, as it just means there was some processor causing some failure and should be updated, but the resources are still active/created. This is the expected behavior.
We can ignore final details/wording at this stage, this will be done in later UX review finalization stages.
This is the expected behavior, mockups may not show everything.
Same comment as previous, this will all be finalized later on. I chose this one over the mockup due to sizing issues currently.
Yes, because if any changes to the ingest pipeline, the data needs to be re-ingested to be processed correctly.
This is a moving target from UX end and still being finalized, current implementation matches previous mocks. This like above callouts around small wording/styling will be finalized later on.
Same comments as above, this is still being finalized.
Same comments as above, this is still being finalized. |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Hi Tyler, thank you for the PR! I'll start reviewing it now. |
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ohltyler, overall looks great to me. This PR looks good to be merged into feature branch.
I will do more testing in all different scenarios and let you know if I find any bug. Overall nav_components and component_input code looks clean
746d95d
into
opensearch-project:feature/editor-refactor
Description
Refactors the workflow detail page, such that users click on a component in the new left nav panel, and configure in the central panel. All components (ingest and search) are viewable altogether from the new left nav. The same guardrails are in place, such that users cannot make changes to the search flow if there are unsaved changes to ingest, and vice versa.
Main component changes:
LeftNav
: the base component with all of the componentsIngestContent
: the accordion of all of the ingest-flow-related componentsSearchContent
: the accordion of all of the search-flow-related componentsComponentInput
: the rough "replacement" ofWorkflowInputs
. Dynamically renders based on the selected component from the left nav. Shows the relevant form input for such selected component.ProcessorsComponent
/ProcessorList
: refactoring of the existingProcessorsList
, as this functionality has now moved as nav components withinLeftNav
.Other implementation details:
disabled
prop to most form input-related components. This is used to still allow users to drill down and view all form details, even for components that are readonly, if the opposite context (ingest or search) has unsaved changes.workflow_inputs
dir =>component_input
WorkflowDetail
component, as all complex state has moved into the childResizableWorkspace
component, as props are not needed to be shared toWorkflowDetailHeader
anymore.NavComponent
, a reusable component for creating each of the clickable cards from the left nav.REGISTER_AGENTS
, as currently there is no native support of this use case on the UI. In the future, we may support agent creation/configuration for different chatbot-related use cases.Next steps for future PRs to this feature branch, before merging back into
main
:Demo video showing the new pattern, new form states, and overall user flow:
left-nav-demo.webm
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.