-
Notifications
You must be signed in to change notification settings - Fork 14
Adding Neural Sparse Search preset #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, overall looking good! Main concern I have is on the usability, and the fact we can't point to easily deployable neural sparse models. We need to ensure that added presets are up to a high bar, such that choosing them will likely mean minimal user inputs to get started.
The fact that there is no standard model (or pattern of inputs/outputs) makes it difficult to automatically configure the input/output mappings of the processors as well.
Let's discuss if there should be added callouts/wording around this particular use case, and have good documentation we can point to regarding the model setup (thanks for adding the proposed models and tutorial!)
public/pages/workflows/new_workflow/quick_configure_optional_fields.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Currently this workflow will be blocked before we merge this Adds Json Parsing to nested object during update Query step in ML Inference Request processor #3856 The limitation was it could not parse the sparse vector to perform neural sparse search. |
Description
Issues Resolved
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.