Skip to content

Adding Neural Sparse Search preset #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Mar 31, 2025

Description

  • Onboarding a new preset for Neural Sparse Search.
  • For development used "opensearch-neural-sparse-encoding-v2-distill" deployed on sagemaker endpoint.
  • Query used in Search Flow is neural_sparse query. (Search the data using a sparse vector)
  • I will upload video.
Screenshot 2025-03-31 at 3 56 15 PM Screenshot 2025-03-31 at 3 56 31 PM Screenshot 2025-03-31 at 3 57 50 PM Screenshot 2025-03-31 at 4 04 18 PM Screenshot 2025-03-31 at 3 58 13 PM Screenshot 2025-03-31 at 3 58 24 PM Screenshot 2025-03-31 at 3 58 45 PM

Issues Resolved

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
@saimedhi saimedhi marked this pull request as ready for review March 31, 2025 23:05
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, overall looking good! Main concern I have is on the usability, and the fact we can't point to easily deployable neural sparse models. We need to ensure that added presets are up to a high bar, such that choosing them will likely mean minimal user inputs to get started.

The fact that there is no standard model (or pattern of inputs/outputs) makes it difficult to automatically configure the input/output mappings of the processors as well.

Let's discuss if there should be added callouts/wording around this particular use case, and have good documentation we can point to regarding the model setup (thanks for adding the proposed models and tutorial!)

saimedhi added 2 commits April 4, 2025 00:41
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
@brianf-aws
Copy link

Currently this workflow will be blocked before we merge this Adds Json Parsing to nested object during update Query step in ML Inference Request processor #3856 The limitation was it could not parse the sparse vector to perform neural sparse search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants