Skip to content

Conversation

stampaaaron
Copy link
Contributor

No description provided.

@stampaaaron stampaaaron linked an issue Oct 16, 2024 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 64c7090

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@quassel/frontend Patch
@quassel/ui Patch
@quassel/mockup Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@openscript openscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's a better idea to use AppShell instead of enrolling our own Header?

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 69.14498% with 83 lines in your changes missing coverage. Please review.

Project coverage is 49.13%. Comparing base (516b41c) to head (64c7090).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
apps/frontend/src/sections/HeroSection.tsx 24.24% 25 Missing ⚠️
apps/frontend/src/routes/__root.tsx 62.06% 22 Missing ⚠️
apps/frontend/src/routes/_auth/administration.tsx 26.66% 11 Missing ⚠️
apps/frontend/src/routes/_auth/questionnaire.tsx 36.36% 7 Missing ⚠️
apps/frontend/src/routes/_auth/index.tsx 40.00% 6 Missing ⚠️
apps/frontend/src/routes/session.tsx 92.42% 5 Missing ⚠️
...frontend/src/routes/_auth/administration/index.tsx 57.14% 3 Missing ⚠️
.../frontend/src/routes/_auth/questionnaire/index.tsx 57.14% 3 Missing ⚠️
apps/frontend/src/stores/i18n.ts 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #103       +/-   ##
===========================================
+ Coverage   23.07%   49.13%   +26.05%     
===========================================
  Files          20       35       +15     
  Lines         169      405      +236     
  Branches        9       16        +7     
===========================================
+ Hits           39      199      +160     
- Misses        127      204       +77     
+ Partials        3        2        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openscript openscript merged commit 33f959b into main Oct 24, 2024
3 checks passed
@openscript openscript deleted the 38-design-visual-elements-and-user-interactions branch October 24, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design visual elements and user interactions

2 participants