Skip to content

Conversation

stampaaaron
Copy link
Contributor

No description provided.

@stampaaaron stampaaaron linked an issue Oct 14, 2024 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 28f3ce0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@quassel/backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@openscript openscript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Probably we need to normalize person and language within the entries, so we don't have troubles to select and aggregate the data later on. So a relation between ExposureEntry and PersonValue as well as LanguageExposure and LanguageValue needs to be created.

@stampaaaron
Copy link
Contributor Author

Looks good to me.

Probably we need to normalize person and language within the entries, so we don't have troubles to select and aggregate the data later on. So a relation between ExposureEntry and PersonValue as well as LanguageExposure and LanguageValue needs to be created later on.

I explicitly didn't add this relation, because custom values will be allowed for both cases. I think it's the easiest way like this. If you have a better idea on how to model this with allowing custom values, let me know.

@stampaaaron stampaaaron merged commit 9c5cbe6 into main Oct 16, 2024
1 check passed
@stampaaaron stampaaaron deleted the 50-plan-database-model branch October 16, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plan database model

2 participants