openscd · noraeb · Aug 21, 2025 · Aug 21, 2025 · Aug 21, 2025 · Aug 21, 2025
diff --git a/.github/workflows/test-on-pr-branch.yml b/.github/workflows/test-on-pr-branch.yml
@@ -3,7 +3,7 @@ on: pull_request
 
 jobs:
   unit:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -22,7 +22,7 @@ jobs:
       - name: Run unit tests
         run: npm run-script test:unit
   visual:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -52,4 +52,4 @@ jobs:
           name: failed_screenshots
           path: |
             screenshots/*/failed/
-            screenshots/*/baseline/
+            screenshots/*/baseline/
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -3,7 +3,7 @@ on: [push, workflow_dispatch]
 
 jobs:
   test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Checkout
         uses: actions/checkout@v3

diff --git a/.github/workflows/update-screenshots.yml b/.github/workflows/update-screenshots.yml
@@ -4,7 +4,7 @@ on: workflow_dispatch
 
 jobs:
   test:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -28,7 +28,7 @@ jobs:
         run: npm run test:update
 
       - name: Upload failed screenshots as artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         if: failure()
         with:
           name: failed_screenshots

diff --git a/editors/sampledvalue/sampled-value-control-element-editor.ts b/editors/sampledvalue/sampled-value-control-element-editor.ts
@@ -170,8 +170,6 @@ export class SampledValueControlElementEditor extends ScopedElementsMixin(
     );
 
     this.resetInputs();
-
-    this.onSampledValueControlInputChange();
   }
 
   private onSMVInputChange(): void {
@@ -472,11 +470,10 @@ export class SampledValueControlElementEditor extends ScopedElementsMixin(
       ><md-text-button
         class="smvcontrol save"
         label="save"
-        icon="save"
         ?disabled=${!this.sampledValueControlDiff}
         @click="${this.saveSampledValueControlChanges}"
-        >Save<md-icon slot="save"></md-icon
-      ></md-text-button>
+        >Save<md-icon slot="icon">save</md-icon></md-text-button
+      >
     </div>`;
   }
 

diff --git a/...-value-control-editor/#10 Create new DataSet inline the selected GSEControl.png b/...-value-control-editor/#10 Create new DataSet inline the selected GSEControl.png
diff --git a/...or/#11 Document shows descriptions in SampledValueControl DataSet 1900x1400.png b/...or/#11 Document shows descriptions in SampledValueControl DataSet 1900x1400.png
diff --git a/...trol/sampled-value-control-editor/#5 Selected SampledValueControl 1900x1200.png b/...trol/sampled-value-control-editor/#5 Selected SampledValueControl 1900x1200.png
diff --git a/...trol/sampled-value-control-editor/#6 Selected SampledValueControl 1200x2000.png b/...trol/sampled-value-control-editor/#6 Selected SampledValueControl 1200x2000.png
diff --git a/...ntrol/sampled-value-control-editor/#6 Selected SampledValueControl 599x2000.png b/...ntrol/sampled-value-control-editor/#6 Selected SampledValueControl 599x2000.png
diff --git a/...ntrol/sampled-value-control-editor/#6 Selected SampledValueControl 800x2000.png b/...ntrol/sampled-value-control-editor/#6 Selected SampledValueControl 800x2000.png
diff --git a/...ue-control-editor/#9 Selected SampledValueControl with unreferenced DataSet.png b/...ue-control-editor/#9 Selected SampledValueControl with unreferenced DataSet.png
diff --git a/...rol/sampled-value-control-element-editor/#2 SampledValueControl without SMV.png b/...rol/sampled-value-control-element-editor/#2 SampledValueControl without SMV.png
diff --git a/...ontrol/sampled-value-control-element-editor/#3 SampledValueControl with SMV.png b/...ontrol/sampled-value-control-element-editor/#3 SampledValueControl with SMV.png
diff --git a/...mpled-value-control-element-editor/#4 SampledValueControl with SMV 599x1100.png b/...mpled-value-control-element-editor/#4 SampledValueControl with SMV 599x1100.png
diff --git a/...mpled-value-control-element-editor/#5 Changed SampledValueControl Attribute.png b/...mpled-value-control-element-editor/#5 Changed SampledValueControl Attribute.png
diff --git a/...ne/smvcontrol/sampled-value-control-element-editor/#6 Changed SMV Attribute.png b/...ne/smvcontrol/sampled-value-control-element-editor/#6 Changed SMV Attribute.png
diff --git a/...mvcontrol/sampled-value-control-element-editor/#7 Changed SmvOpts Attribute.png b/...mvcontrol/sampled-value-control-element-editor/#7 Changed SmvOpts Attribute.png