fix: performance issues #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clepski
requested changes
Jul 28, 2025
| this.selectionList.searchValue = this.searchValue; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do all editors have the same property and update code? If so we can move it into the baseclass BaseElementEditor
There was a problem hiding this comment.
Good idea, fixed that
oscd-publisher.ts
Outdated
Comment on lines
83
to
105
| @search-change=${this.handleSearchChange('Report')} | ||
| ></report-control-editor>`; | ||
| case 'GOOSE': | ||
| return html`<gse-control-editor | ||
| .doc=${this.doc} | ||
| .editCount=${this.editCount} | ||
| .searchValue=${this.filterValues.GOOSE} | ||
| @search-change=${this.handleSearchChange('GOOSE')} | ||
| ></gse-control-editor>`; | ||
| case 'SampledValue': | ||
| return html`<sampled-value-control-editor | ||
| .doc=${this.doc} | ||
| .editCount=${this.editCount} | ||
| .searchValue=${this.filterValues.SampledValue} | ||
| @search-change=${this.handleSearchChange('SampledValue')} | ||
| ></sampled-value-control-editor>`; | ||
| case 'DataSet': | ||
| return html`<data-set-editor | ||
| .doc=${this.doc} | ||
| .editCount=${this.editCount} | ||
| .searchValue=${this.filterValues.DataSet} | ||
| @search-change=${this.handleSearchChange('DataSet')} | ||
| ></data-set-editor>`; |
There was a problem hiding this comment.
Are the @search-change still relevant? It seems like the value is stored when the tab changes and I dont see any search-change events being fired
There was a problem hiding this comment.
No you are right, I forgot to remove them, just fixed it
clepski
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4