Get rid of duplicate definitions that trip up typescript #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two variables in QueryEditor.tsx were duplicated (and identical): isInDashboard and getTimeStampColumnName. This change deletes the second one, which makes typescript happy.
|
Honestly not sure how to make the "compat check" check pass, but I take the build making it past the "build plugin" step as a good sign (: |
|
@antifuchs Change this line https://github.com/openobserve/openobserve-grafana-plugin/blob/main/.github/workflows/is-compatible.yml#L12 to Node 16 is no longer supported that's why compat fails. |
|
The package.json also needs to be updated to use >=18 engine https://github.com/openobserve/openobserve-grafana-plugin/blob/main/package.json#L60 |
jealouscloud
added a commit
to jealouscloud/openobserve-grafana-plugin-fixes
that referenced
this pull request
Jan 8, 2025
hengfeiyang
pushed a commit
that referenced
this pull request
Mar 4, 2025
* fix: getField * Fix bug which skips the first column regardless of if it is a timestamp * date(timestamp + "Z") was breaking timestamps. Use whatever O2 gives us, unless it's microseconds which needs converting to MS. * Only add Time column if it's part of the request [breaking for queries relying on this implicit field, but deduplicating for the queries that manually request it including example requests] * fix: getGraphDataFrame * [bugfix] No longer skip first requested column * [bugfix] Remove type: number for non-time fields which breaks string responses * Detect timestamp column in request * fix: Add getColumnsFromQuery quote stripping [big] The dataframe parser would fail to assign fields wrapped in quotes i.e. select 1 as "server" * change: Utilize datasource defined timestamp column automatically in data frame parser * Implement #14 fix in #15 to pass tests
hengfeiyang
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two variables in QueryEditor.tsx were duplicated (and identical): isInDashboard and getTimeStampColumnName. This change deletes the second one, which makes typescript happy.
This fixes #14.