fix(edge-converter): Ensure null body status codes dont return a body #906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For opennextjs/opennextjs-cloudflare#684
We need to ensure that the response doesn't return a body if its a status code that does not allow it. (101, 204, 205, 304).
Here is a reproduction I made for that issue. To run the reproduction just
pnpm install && pnpm preview
. Then in another terminal youcurl -i http://localhost:8787/src2
.We could fix this inside the
overrides/proxyExternalRequest/fetch.ts
aswell. We would just return the body as is, and not fallback toemptyReadableStream()
. Not sure what would be preferred? I dont thinkemptyReadableStream()
has any effect in this converter.