Skip to content

refactor: Use diff in patch tests rather than raw output #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jun 10, 2025

IMO it makes the tests much more readable

Copy link

changeset-bot bot commented Jun 10, 2025

⚠️ No Changeset found

Latest commit: 87e1e52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jun 10, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@899

commit: 87e1e52

Copy link
Contributor

github-actions bot commented Jun 10, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.89% 2606 / 9689
🔵 Statements 26.89% 2606 / 9689
🔵 Functions 53.72% 137 / 255
🔵 Branches 73.3% 615 / 839
File CoverageNo changed files found.
Generated in workflow #1308 for commit 31e4bae by the Vitest Coverage Report Action

@vicb vicb marked this pull request as ready for review June 10, 2025 12:12
@vicb vicb requested a review from conico974 June 10, 2025 12:12
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah great things to add, some of the test were barely readable.
Just a little nit

@vicb vicb merged commit f1d4a4b into main Jun 10, 2025
1 check passed
@vicb vicb deleted the vicb/diff branch June 10, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants