refactor: merge dropBabel into patchNextServer

[vicb]

minimalRule is not needed any more because it is superseded by createEmptyBodyRules.

createEmptyBodyRules are preferred because they actually empty the function body.

The effect of minimalRule was:

method(args) {
  if (true) {
    throw new Error(...);
  }

  // ESBuild does not tree shake code after early return/throw
  thisIsPullingADependency();
}

Details:

• minimalRule is removed
• The patches are moved over from drop babel
• The body of NextServer#imageOptimizer is emptied (was handled by minimalRule before).
• Update the tests.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d320cdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	26.89%	2606 / 9689
🔵	Statements	26.89%	2606 / 9689
🔵	Functions	53.72%	137 / 255
🔵	Branches	73.3%	615 / 839

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/open-next/src/build/createServerBundle.ts	0%	0%	0%	0%	1-389
packages/open-next/src/build/patch/patches/index.ts	0%	0%	0%	0%	1
packages/open-next/src/build/patch/patches/patchNextServer.ts	100%	100%	100%	100%

Generated in workflow #1302 for commit d320cdd by the Vitest Coverage Report Action

[pkg-pr-new]

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@894

commit: d320cdd

[conico974]

LGTM Thanks

[vicb]

Thanks for the review Nico!