UIFR-226: Added support for Bamboo Specs. #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkayiwa
reviewed
Jun 9, 2025
bamboo-specs/bamboo.yml
Outdated
|
|
||
| docker pull ${IMAGE} | ||
|
|
||
| docker run -v m2-repo:/root/.m2/repository -v ${PWD}:/module --rm -w="/module" ${IMAGE} bash -c 'chmod -R 777 .' |
There was a problem hiding this comment.
Why are we running docker twice for each Java version?
There was a problem hiding this comment.
The difference is in the executed command for each of the docker runs. This here, is a task that should run before the main source-code checkout task and consequently before the main maven build task. This particular task (a docker run script involving ... chmod -R .) particularly helps to resolve file permission effects of previous builds or build-failures.
There was a problem hiding this comment.
Should be resolved as agreed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Bamboo Specs, involving JDK 8, 11, 17, 21 and 24
Ticket: https://openmrs.atlassian.net/browse/UIFR-226