UIFR-226: Update to OpenMRS platform 2.7.3 and Support Java 21 #87

wikumChamith · 2025-05-01T10:37:02Z

Ticket: https://openmrs.atlassian.net/browse/UIFR-226

wikumChamith · 2025-05-01T11:09:41Z

I'm encountering a test error when running with Java 17, but the same tests pass without issues on Java 21 and Java 24. Any idea what might be causing this?

https://gist.github.com/wikumChamith/c207c6b890e88e42c0f8ee4bd00a6297

ibacher · 2025-05-01T13:04:26Z

The most common cause I see from a quick search is having the wrong version of byte-buddy on the classpath... It needs 1.12+. Alternatively, maybe we can drop the dependency on PowerMock? It only seems to be used for this import and is notoriously fragile to version changes.

mseaton

Generally looks good to me @wikumChamith , nice work. A few comments for consideration

mseaton · 2025-05-01T13:21:18Z

.github/workflows/maven.yml

@@ -13,7 +13,7 @@ jobs:

    strategy:
      matrix:
-        java-version: [8, 11, 17]
+        java-version: [8, 11, 21, 24]


Would be good to figure out why 17 doesn't work, and fix it and support it.

mseaton · 2025-05-01T13:22:05Z

api/pom.xml

 		<dependency>
 			<groupId>javax.servlet</groupId>
-			<artifactId>servlet-api</artifactId>
+			<artifactId>javax.servlet-api</artifactId>


Can we eliminate the need for this dependency in the api module while we are at this? Not really in the scope of this ticket, but generally the API should not have this kind of web dependency.

mseaton · 2025-05-01T13:22:50Z

pom.xml

@@ -43,17 +37,17 @@
    </modules>

    <properties>
-        <openmrsPlatformVersion>2.0.0</openmrsPlatformVersion>
-        <springVersion>4.1.4.RELEASE</springVersion>
+        <openmrsPlatformVersion>2.7.3</openmrsPlatformVersion>


Can this be 2.7.0, or does it need to be 2.7.3?

mseaton · 2025-05-01T13:22:59Z

pom.xml

-        <openmrsPlatformVersion>2.0.0</openmrsPlatformVersion>
-        <springVersion>4.1.4.RELEASE</springVersion>
+        <openmrsPlatformVersion>2.7.3</openmrsPlatformVersion>
+        <springVersion>5.3.30</springVersion>


Is this still used?

mseaton · 2025-05-01T13:23:39Z

pom.xml

-                        <target>1.7</target>
-                        <source>1.7</source>
+                        <target>1.8</target>
+                        <source>1.8</source>


Nit: should this just be 8 now?

Yes, we need to set the source to at least Java 8 to compile with Java 21.

wikumChamith · 2025-05-01T13:36:20Z

The most common cause I see from a quick search is having the wrong version of byte-buddy on the classpath... It needs 1.12+. Alternatively, maybe we can drop the dependency on PowerMock? It only seems to be used for this import and is notoriously fragile to version changes.

I tried adding both byte-buddy and byte-buddy-agent, but still got the error. Adding powermock as an exclusion worked.

ibacher · 2025-05-01T13:39:48Z

Is there a reason we're testing with Java 24? I'd prefer not to make things dependent on non-LTS releases of the JDK, as they generally have a 6-month lifespan and are then retired.

wikumChamith · 2025-05-01T13:42:14Z

Is there a reason we're testing with Java 24? I'd prefer not to make things dependent on non-LTS releases of the JDK, as they generally have a 6-month lifespan and are then retired.

I decided to add this because now we have a Java 24 build in core: openmrs/openmrs-core@2aa544c.

In the last platform meeting, @dkayiwa explained that we should try to support the latest version of JDK even if it is not an LTS.

dkayiwa · 2025-05-05T23:42:22Z

pom.xml

+            <dependency>
+                <groupId>net.bytebuddy</groupId>
+                <artifactId>byte-buddy</artifactId>
+                <version>1.15.10</version>


shouldn't you add scope to these?

@wikumChamith did you see the above comment?

Yeah. I'll update this

@dkayiwa I updated the PR.

wikumChamith · 2025-05-13T12:04:05Z

@dkayiwa, @ibacher, any guesses on what is causing the error with the GitHub build? I am not seeing this error when compiling the module locally.

dkayiwa · 2025-05-13T13:44:40Z

I get the same exact error when i compile locally

wikumChamith · 2025-05-13T15:47:46Z

I get the same exact error when i compile locally

Here is my log: https://pastebin.com/Lrgb6sj5

dkayiwa · 2025-05-13T18:42:18Z

@wikumChamith try changing the failing test's base class to org.openmrs.web.test.jupiter.BaseModuleWebContextSensitiveTest and the Test annotation to org.junit.jupiter.api.Test

…veTest

wikumChamith · 2025-05-14T09:18:16Z

@wikumChamith try changing the failing test's base class to org.openmrs.web.test.jupiter.BaseModuleWebContextSensitiveTest and the Test annotation to org.junit.jupiter.api.Test

That fixed the issue. Do you know why I was not getting the error locally?

dkayiwa · 2025-05-14T18:37:29Z

Where you compiling from your IDE?

wikumChamith · 2025-05-14T18:38:41Z

Where you compiling from your IDE?

Tried on both the IDE and terminal.

dkayiwa · 2025-05-14T18:46:31Z

Did you try with more than one version of Java?

wikumChamith · 2025-05-14T18:48:55Z

Did you try with more than one version of Java?

Yeah, Java 8,17,21 and 24. Anyway your suggestion fixed the issue on GitHub :)

dkayiwa · 2025-05-19T09:52:35Z

Are we going to create a branch for lower platform versions? And also bump the version of the module?

wikumChamith · 2025-05-19T09:55:34Z

Are we going to create a branch for lower platform versions? And also bump the version of the module?

Yes. I created a new branch: https://github.com/openmrs/openmrs-module-uiframework/tree/3.x

wikumChamith force-pushed the UIFR-226 branch 3 times, most recently from 28699df to 5d5c92e Compare May 1, 2025 10:55

UIFR-226: Update to OpenMRS platform 2.7.3 and Support Java 21

c1cfb45

wikumChamith force-pushed the UIFR-226 branch from 5d5c92e to c1cfb45 Compare May 1, 2025 10:58

wikumChamith requested review from dkayiwa, mogoodrich, mseaton and ibacher and removed request for dkayiwa May 1, 2025 11:05

mseaton approved these changes May 1, 2025

View reviewed changes

Exclude powermock

4072d2d

Add Java 17 to the Github Build

47e1dc5

wikumChamith requested a review from mseaton May 1, 2025 13:47

wikumChamith mentioned this pull request May 5, 2025

SDK-380: Add support for Java 24 openmrs/openmrs-sdk#330

Merged

5 tasks

dkayiwa reviewed May 5, 2025

View reviewed changes

wikumChamith force-pushed the UIFR-226 branch 2 times, most recently from 37f1231 to 473a4f8 Compare May 12, 2025 05:52

Change the platform version to 2.7.0

154f3ad

wikumChamith force-pushed the UIFR-226 branch from 473a4f8 to 154f3ad Compare May 12, 2025 05:59

wikumChamith added 2 commits May 12, 2025 11:36

Change the platform version to 2.7.3

0528e1f

Change the platform version to 2.7.0

f0f6317

wikumChamith force-pushed the UIFR-226 branch from f0f6317 to 47e1dc5 Compare May 12, 2025 09:12

Only Java 8 Github build

035b593

wikumChamith force-pushed the UIFR-226 branch from 035b593 to 4072d2d Compare May 12, 2025 09:23

Add Java 11+ builds

460fa3d

Change to coretto

2fb71e4

wikumChamith force-pushed the UIFR-226 branch from f6032df to 2fb71e4 Compare May 13, 2025 15:40

Switching to org.openmrs.web.test.jupiter.BaseModuleWebContextSensiti…

ca11deb

…veTest

wikumChamith force-pushed the UIFR-226 branch from ddfb514 to ca11deb Compare May 14, 2025 09:17

Setting the version to 4.0.0-SNAPSHOT

076a610

wikumChamith requested a review from dkayiwa May 19, 2025 09:55

dkayiwa merged commit ba0dc6b into openmrs:master May 19, 2025
5 checks passed

UIFR-226: Update to OpenMRS platform 2.7.3 and Support Java 21 #87

UIFR-226: Update to OpenMRS platform 2.7.3 and Support Java 21 #87

Uh oh!

Conversation

wikumChamith commented May 1, 2025

Uh oh!

wikumChamith commented May 1, 2025

Uh oh!

ibacher commented May 1, 2025

Uh oh!

mseaton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wikumChamith May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wikumChamith commented May 1, 2025

Uh oh!

ibacher commented May 1, 2025

Uh oh!

wikumChamith commented May 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wikumChamith commented May 13, 2025

Uh oh!

dkayiwa commented May 13, 2025

Uh oh!

wikumChamith commented May 13, 2025

Uh oh!

dkayiwa commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wikumChamith commented May 14, 2025

Uh oh!

dkayiwa commented May 14, 2025

Uh oh!

wikumChamith commented May 14, 2025

Uh oh!

dkayiwa commented May 14, 2025

Uh oh!

wikumChamith commented May 14, 2025

Uh oh!

dkayiwa commented May 19, 2025

Uh oh!

wikumChamith commented May 19, 2025

Uh oh!

Uh oh!

Uh oh!

wikumChamith May 1, 2025 •

edited

Loading

dkayiwa commented May 13, 2025 •

edited

Loading