Skip to content
This repository was archived by the owner on Jun 26, 2025. It is now read-only.

Conversation

@jwnasambu
Copy link

@jwnasambu jwnasambu commented Dec 10, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Previously, the home workspace container rendered as an overlay that covered existing content. Now it renders as a standard workspace that pushes content on the page to the left, matching the behavior in other parts of the application. The key changes this PR makes is removing the overlay prop from the workspace container, which effectively turns it into a standard workspace.

Screenshots

Screenshot 2024-12-10 at 10 14 52 PM

Related issue

https://openmrs.atlassian.net/browse/O3-4159

Other

@jwnasambu
Copy link
Author

Hello, @brandones, kindly feel free to review my PR at your convenient time please.

@denniskigen denniskigen changed the title fix/O3-4159: Side panel (workspace) should not cover content on Service Queues page (fix) O3-4159: Workspace should not cover content on service queues page Jan 27, 2025
<DashboardView title={activeDashboard?.name} dashboardSlot={activeDashboard?.slot} />
</section>
<WorkspaceContainer overlay contextKey="home" />
<WorkspaceContainer contextKey="home" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will be made for all the workspaces shown on the /home path, which also includes Wards Workspaces and others.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasharma05, You are right, and I raised the same question during the coffee break (10 Dec 2024) while we were debugging the issue. My suggestion then was to avoid affecting other workspaces by ensuring that each workspace has its own WorkspaceContainer component, with an overlay on top of the content to simplify styling without affecting other workspaces. The main essence of pushing this PR was to get members' views after implementing what @brandones had suggested on the ticket.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants