Skip to content

Add incubating projects to README #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Add incubating projects to README #901

merged 3 commits into from
Jul 14, 2022

Conversation

jorydotcom
Copy link
Contributor

Adds Jest, vis.gl and kepler.gl to incubating projects list.

Signed-off-by: Jory Burson jory@thestoryofjory.com

Adds Jest, vis.gl and kepler.gl to incubating projects list. 

Signed-off-by: Jory Burson <jory@thestoryofjory.com>
Copy link
Member

@WaleedAshraf WaleedAshraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tiny change: updated links to blob/HEAD, to keep consistency with existing links in the file.

Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @WaleedAshraf suggestions are integrated

Co-authored-by: Waleed Ashraf <waleedashraf@outlook.com>

Signed-off-by: Tobie Langel <tobie@unlockopen.com>
Signed-off-by: Waleed Ashraf <waleedashraf@outlook.com>
@WaleedAshraf
Copy link
Member

The "https://opensource.org" links are failing. Maybe we should add them to the exception list.

@WaleedAshraf WaleedAshraf self-requested a review July 14, 2022 14:13
@WaleedAshraf WaleedAshraf merged commit 9446f50 into main Jul 14, 2022
@WaleedAshraf WaleedAshraf deleted the jorydotcom-patch-1 branch July 14, 2022 14:13
tobie added a commit that referenced this pull request Sep 1, 2023
* Add incubating projects to README

Adds Jest, vis.gl and kepler.gl to incubating projects list. 

Signed-off-by: Jory Burson <jory@thestoryofjory.com>

* Apply suggestions from code review

Co-authored-by: Waleed Ashraf <waleedashraf@outlook.com>

Signed-off-by: Tobie Langel <tobie@unlockopen.com>

* update Contributing link for json-schema-spec

Signed-off-by: Waleed Ashraf <waleedashraf@outlook.com>

Co-authored-by: Tobie Langel <tobie@unlockopen.com>
Co-authored-by: Waleed Ashraf <waleedashraf@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants