8354244: Use random data in MinMaxRed_Long data arrays

[galderz]

Simplified the data used in the tests added in JDK-8307513. The data does not need to have a specific shape because this test focuses on verifying the IR when vectorization kicks in, and when it does, the data can just be random. Shaping the data to control branch taken/not-taken paths makes sense when CMov macro expansion kicks in instead of vectorization.

When switching to random data I noticed that the test was randomly failing. This was due to potential overflows that result from takin the min/max and then multiplying it by 11, so I've adjusted that section of the test as well.

I've run the test on both aarch64 and x64 platforms where this test would get vectorized. To verify that I made sure the test passed and verified that the jtr output to make sure the IR conditions were matched.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354244: Use random data in MinMaxRed_Long data arrays (Enhancement - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Manuel Hässig (@mhaessig - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26451/head:pull/26451
$ git checkout pull/26451

Update a local copy of the PR:
$ git checkout pull/26451
$ git pull https://git.openjdk.org/jdk.git pull/26451/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26451

View PR using the GUI difftool:
$ git pr show -t 26451

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26451.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back galder! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@galderz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354244: Use random data in MinMaxRed_Long data arrays

Reviewed-by: chagedorn, mhaessig

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 67e9328: 8363357: Remove unused flag VerifyAdapterCalls
• ed9066b: 8361478: GHA: Use MSYS2 from GHA runners
• 7a22b76: 8362591: Wrong argument warning when heap size larger than coops threshold
• ... and 26 more: https://git.openjdk.org/jdk/compare/ac141c2fa1d818858e7a12a50837bb282282ecac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @mhaessig) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@galderz The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (166465ad)

[chhagedorn]

Nice clean-up by using the Generators. Looks good to me! Let me submit some testing with the updated test only.

[mhaessig]

Thank you for this nice simplification, @galderz! It looks good to me as well.