8360679: Shenandoah: AOT saved adapter calls into broken GC barrier stub

[shipilev]

See the bug for more analysis. This is AOT-, AArch64-, Shenandoah-specific problem. The fix is simple, the failure is catastrophic, and it is very reproducible. So it makes the issue P2, and would like to get it into JDK 25 under RDP 2 rules.

Additional testing:

• Linux AArch64 server fastdebug, mainline, runtime/cds with -XX:+UseShenandoahGC (now passes)
• Linux AArch64 server fastdebug, mainline, hotspot_gc_shenandoah (still passes)
• Linux AArch64 server fastdebug, JDK 25, runtime/cds with -XX:+UseShenandoahGC (now passes)
• Linux AArch64 server fastdebug, JDK 25, hotspot_gc_shenandoah (still passes)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360679: Shenandoah: AOT saved adapter calls into broken GC barrier stub (Bug - P2)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Andrew Dinn (@adinn - Reviewer)
• Andrew Haley (@theRealAph - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26449/head:pull/26449
$ git checkout pull/26449

Update a local copy of the PR:
$ git checkout pull/26449
$ git pull https://git.openjdk.org/jdk.git pull/26449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26449

View PR using the GUI difftool:
$ git pr show -t 26449

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26449.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360679: Shenandoah: AOT saved adapter calls into broken GC barrier stub

Reviewed-by: kvn, adinn, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• ed9066b: 8361478: GHA: Use MSYS2 from GHA runners
• 7a22b76: 8362591: Wrong argument warning when heap size larger than coops threshold
• 0ba2942: 8362838: RISC-V: Incorrect matching rule leading to improper oop instruction encoding
• ... and 6 more: https://git.openjdk.org/jdk/compare/594c080b2bde81a48ecccda85ac765218fc93856...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• hotspot
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (2276e884)

[vnkozlov]

Good catch.

I assume on x86 it is fine.

[vnkozlov]

I am fine with back porting this into JDK 25. Please, file request according to https://openjdk.org/jeps/3#Fix-Request-Process

[shipilev]

I assume on x86 it is fine.

Yes, because on x86 we do the proper VM call. I filed JDK-8363974 to clean that up. After that is done, we will bring the follow-up fix to 25u. Meanwhile, we want to unbreak JDK 25 GA.

[adinn]

Nice catch!

[shipilev]

I am fine with back porting this into JDK 25. Please, file request according to https://openjdk.org/jeps/3#Fix-Request-Process

Thanks! Request filed.

[shipilev]

Thank you all! Here goes the mainline integration.

/integrate

[openjdk]

Going to push as commit 8477630.
Since your change was applied there have been 11 commits pushed to the master branch:

• 2f1aed2: 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java
• 67e9328: 8363357: Remove unused flag VerifyAdapterCalls
• ed9066b: 8361478: GHA: Use MSYS2 from GHA runners
• ... and 8 more: https://git.openjdk.org/jdk/compare/594c080b2bde81a48ecccda85ac765218fc93856...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 8477630.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[shipilev]

JDK 25 backport: #26464