Skip to content

8363965: GHA: Switch cross-compiling sysroots to Debian bookworm #26447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 23, 2025

I have noticed that GHA jobs started to fail when creating ppc64el sysroot. We are using Debian bullseye as the base for sysroots. Debian bullseye is LTS release. Perhaps counter-intuitively, LTS platform support shrinks over the LTS lifetime. Debian wiki: https://wiki.debian.org/LTS/Using -- says:

"Important: The current LTS version is Debian 11 ("bullseye") and will be supported until August 31st, 2026. Supported architectures in Debian 11 LTS are limited to amd64, i386, arm64 and armhf. Users of other architectures are especially encouraged to upgrade to Debian 12 (''bookworm''). "

We should consider switching to Debian bookworm for GHA cross-compiling sysroots. Again, Debian wiki: https://wiki.debian.org/DebianBookworm#Architectures -- says all architectures we need are supported. But actually, RISC-V is still only supported with sid. So, we need to be switching only current bullseye to bookworm, leaving sid as sid. This should change as Debian trixie releases in a few weeks, but we cannot wait for this long. Debian trixie update would be handled in JDK-8363966.

Additional testing:

  • GHA cross-compilation jobs

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8363965: GHA: Switch cross-compiling sysroots to Debian bookworm (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26447/head:pull/26447
$ git checkout pull/26447

Update a local copy of the PR:
$ git checkout pull/26447
$ git pull https://git.openjdk.org/jdk.git pull/26447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26447

View PR using the GUI difftool:
$ git pr show -t 26447

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26447.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363965: GHA: Switch cross-compiling sysroots to Debian bookworm

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 23, 2025
@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jul 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2025

Webrevs

@shipilev
Copy link
Member Author

GHA cross-compilation jobs are green. I think we are ready for reviews/integration.

@shipilev
Copy link
Member Author

I believe we need it in GHA now, as I see only the GHA jobs that have cached sysroot are not failing. This also applies to update releases, @TheRealMDoerr @RealCLanger @jerboaa :)

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense in order to keep all platforms active.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 24, 2025
@shipilev
Copy link
Member Author

Thanks! More reviews, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants