-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8363965: GHA: Switch cross-compiling sysroots to Debian bookworm #26447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
GHA cross-compilation jobs are green. I think we are ready for reviews/integration. |
I believe we need it in GHA now, as I see only the GHA jobs that have cached sysroot are not failing. This also applies to update releases, @TheRealMDoerr @RealCLanger @jerboaa :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense in order to keep all platforms active.
Thanks! More reviews, please? |
I have noticed that GHA jobs started to fail when creating ppc64el sysroot. We are using Debian bullseye as the base for sysroots. Debian bullseye is LTS release. Perhaps counter-intuitively, LTS platform support shrinks over the LTS lifetime. Debian wiki: https://wiki.debian.org/LTS/Using -- says:
"Important: The current LTS version is Debian 11 ("bullseye") and will be supported until August 31st, 2026. Supported architectures in Debian 11 LTS are limited to amd64, i386, arm64 and armhf. Users of other architectures are especially encouraged to upgrade to Debian 12 (''bookworm''). "
We should consider switching to Debian bookworm for GHA cross-compiling sysroots. Again, Debian wiki: https://wiki.debian.org/DebianBookworm#Architectures -- says all architectures we need are supported. But actually, RISC-V is still only supported with sid. So, we need to be switching only current bullseye to bookworm, leaving sid as sid. This should change as Debian trixie releases in a few weeks, but we cannot wait for this long. Debian trixie update would be handled in JDK-8363966.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26447/head:pull/26447
$ git checkout pull/26447
Update a local copy of the PR:
$ git checkout pull/26447
$ git pull https://git.openjdk.org/jdk.git pull/26447/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26447
View PR using the GUI difftool:
$ git pr show -t 26447
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26447.diff
Using Webrev
Link to Webrev Comment