8363720: Follow up to JDK-8360411 with post review comments #26445
+27
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of post review comments after the /integrate command was submitted. This issue will address those comments. Also created constants for hardcoded values and tests. Fixed some typos.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26445/head:pull/26445
$ git checkout pull/26445
Update a local copy of the PR:
$ git checkout pull/26445
$ git pull https://git.openjdk.org/jdk.git pull/26445/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26445
View PR using the GUI difftool:
$ git pr show -t 26445
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26445.diff
Using Webrev
Link to Webrev Comment