-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8363929: G1: Add G1 prefix to various G1 specific global locks #26444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/label add hotspot-gc |
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@tschatzl |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, just needs a few more cosmetics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine!
Hi all,
please review this renaming of a few G1 specific locks to have a G1 prefix to make it clear that they should not be used elsewhere.
Testing: local compilation, gha
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26444/head:pull/26444
$ git checkout pull/26444
Update a local copy of the PR:
$ git checkout pull/26444
$ git pull https://git.openjdk.org/jdk.git pull/26444/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26444
View PR using the GUI difftool:
$ git pr show -t 26444
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26444.diff
Using Webrev
Link to Webrev Comment