Skip to content

8363929: G1: Add G1 prefix to various G1 specific global locks #26444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 23, 2025

Hi all,

please review this renaming of a few G1 specific locks to have a G1 prefix to make it clear that they should not be used elsewhere.

Testing: local compilation, gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8363929: G1: Add G1 prefix to various G1 specific global locks (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26444/head:pull/26444
$ git checkout pull/26444

Update a local copy of the PR:
$ git checkout pull/26444
$ git pull https://git.openjdk.org/jdk.git pull/26444/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26444

View PR using the GUI difftool:
$ git pr show -t 26444

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26444.diff

Using Webrev

Link to Webrev Comment

Hi all,

  please review this renaming of a few G1 specific locks to have a G1 prefix to make it clear that they should not be used elsewhere.

Testing: local compilation, gha

Thanks,
  Thomas
@tschatzl
Copy link
Contributor Author

/label add hotspot-gc

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2025

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363929: G1: Add G1 prefix to various G1 specific global locks

Reviewed-by: shade, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8363929 8363929: G1: Add G1 prefix to various G1 specific global locks Jul 23, 2025
@openjdk openjdk bot added rfr Pull request is ready for review hotspot-gc hotspot-gc-dev@openjdk.org labels Jul 23, 2025
@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@tschatzl
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 23, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 23, 2025
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, just needs a few more cosmetics.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 24, 2025
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants