8363676: [GCC static analyzer] missing return value check of malloc in OGLContext_SetTransform #26443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the GCC static analyzer (-fanalyzer) the following issue is reported :
src/java.desktop/share/native/common/java2d/opengl/OGLContext.c:487:9: warning: use of possibly-NULL '*oglc.xformMatrix' where non-null expected [CWE-690] [-Wanalyzer-possible-null-argument]
Seems we miss a NULL check of the return value of malloc (at most other places in the coding we do it).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26443/head:pull/26443
$ git checkout pull/26443
Update a local copy of the PR:
$ git checkout pull/26443
$ git pull https://git.openjdk.org/jdk.git pull/26443/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26443
View PR using the GUI difftool:
$ git pr show -t 26443
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26443.diff
Using Webrev
Link to Webrev Comment