Skip to content

8363357: Remove unused flag VerifyAdapterCalls #26440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

marc-chevalier
Copy link
Member

@marc-chevalier marc-chevalier commented Jul 23, 2025

It seems that the flag VerifyAdapterCalls is unused since JDK-8350209, so pretty recently.

Let's remove it, very direct, no trick.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8363357: Remove unused flag VerifyAdapterCalls (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26440/head:pull/26440
$ git checkout pull/26440

Update a local copy of the PR:
$ git checkout pull/26440
$ git pull https://git.openjdk.org/jdk.git pull/26440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26440

View PR using the GUI difftool:
$ git pr show -t 26440

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26440.diff

Using Webrev

Link to Webrev Comment

@marc-chevalier marc-chevalier changed the title Remove VerifyAdapterCalls 8363357: Remove unused flag VerifyAdapterCalls Jul 23, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2025

👋 Welcome back mchevalier! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@marc-chevalier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363357: Remove unused flag VerifyAdapterCalls

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@marc-chevalier The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 23, 2025
@marc-chevalier
Copy link
Member Author

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 23, 2025
@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@marc-chevalier
The hotspot-compiler label was successfully added.

@marc-chevalier marc-chevalier marked this pull request as ready for review July 23, 2025 10:07
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2025

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 23, 2025
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@marc-chevalier
Copy link
Member Author

/integrate

Thanks @chhagedorn & @TobiHartmann!

@openjdk
Copy link

openjdk bot commented Jul 24, 2025

Going to push as commit 67e9328.
Since your change was applied there have been 27 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 24, 2025
@openjdk openjdk bot closed this Jul 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 24, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@marc-chevalier Pushed as commit 67e9328.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants