-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8315131: Clarify VarHandle set/get access on 32-bit platforms #26438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed changes identical to those already in master
.
Thanks for the reviews! /integrate |
Going to push as commit 1867eff. |
JDK-8315131 addresses a doc-only mistake present on release 25. Since this is doc-only, this is eligible for backport, and its CSR is approved for release 25 too. See #26258 for the original PR review.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26438/head:pull/26438
$ git checkout pull/26438
Update a local copy of the PR:
$ git checkout pull/26438
$ git pull https://git.openjdk.org/jdk.git pull/26438/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26438
View PR using the GUI difftool:
$ git pr show -t 26438
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26438.diff
Using Webrev
Link to Webrev Comment