8357818: Shenandoah doesn't use shared API for printing heap before/after GC

[rgithubli]

Add logging for Shenandoah as well as Generational Shenandoah.

Log samples:

######################################
Before gc
######################################
[0.231s][debug][gc,heap      ] GC(0) Heap Before GC invocations=0 (full 0):
[0.231s][debug][gc,heap      ] GC(0)  Shenandoah Heap
[0.231s][debug][gc,heap      ] GC(0)   100M max, 100M soft max, 100M committed, 39686K used
[0.231s][debug][gc,heap      ] GC(0)   400 x 256 K regions
[0.231s][debug][gc,heap      ] GC(0)  Status: not cancelled
[0.231s][debug][gc,heap      ] GC(0)  Reserved region:
[0.231s][debug][gc,heap      ] GC(0)   - [0x00000000f9c00000, 0x0000000100000000) 
[0.231s][debug][gc,heap      ] GC(0)  Collection set:
[0.231s][debug][gc,heap      ] GC(0)   - map (vanilla): 0x0000000000004e70
[0.231s][debug][gc,heap      ] GC(0)   - map (biased):  0x0000000000001000
[0.231s][debug][gc,heap      ] GC(0) 
[0.231s][debug][gc,metaspace ] GC(0) Metaspace Before GC invocations=0 (full 0):
[0.231s][debug][gc,metaspace ] GC(0)  Metaspace       used 153K, committed 384K, reserved 1114112K
[0.231s][debug][gc,metaspace ] GC(0)   class space    used 3K, committed 128K, reserved 1048576K




######################################
After gc
######################################
[2.067s][debug][gc,heap        ] GC(11) Heap After GC invocations=0 (full 0):
[2.067s][debug][gc,heap        ] GC(11)  Shenandoah Heap
[2.067s][debug][gc,heap        ] GC(11)   100M max, 100M soft max, 100M committed, 101356K used
[2.067s][debug][gc,heap        ] GC(11)   400 x 256 K regions
[2.067s][debug][gc,heap        ] GC(11)  Status: not cancelled
[2.067s][debug][gc,heap        ] GC(11)  Reserved region:
[2.067s][debug][gc,heap        ] GC(11)   - [0x00000000f9c00000, 0x0000000100000000) 
[2.067s][debug][gc,heap        ] GC(11)  Collection set:
[2.067s][debug][gc,heap        ] GC(11)   - map (vanilla): 0x0000000000004e70
[2.067s][debug][gc,heap        ] GC(11)   - map (biased):  0x0000000000001000
[2.067s][debug][gc,heap        ] GC(11) 
[2.067s][debug][gc,metaspace   ] GC(11) Metaspace After GC invocations=0 (full 0):
[2.067s][debug][gc,metaspace   ] GC(11)  Metaspace       used 190K, committed 384K, reserved 1114112K
[2.067s][debug][gc,metaspace   ] GC(11)   class space    used 4K, committed 128K, reserved 1048576K

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357818: Shenandoah doesn't use shared API for printing heap before/after GC (Enhancement - P4)

Reviewers

• William Kemper (@earthling-amzn - Reviewer)
• Kelvin Nilsen (@kdnilsen - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26272/head:pull/26272
$ git checkout pull/26272

Update a local copy of the PR:
$ git checkout pull/26272
$ git pull https://git.openjdk.org/jdk.git pull/26272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26272

View PR using the GUI difftool:
$ git pr show -t 26272

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26272.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rgithubli This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357818: Shenandoah doesn't use shared API for printing heap before/after GC

Reviewed-by: wkemper, kdnilsen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 189 new commits pushed to the master branch:

• 8477630: 8360679: Shenandoah: AOT saved adapter calls into broken GC barrier stub
• 2f1aed2: 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java
• 67e9328: 8363357: Remove unused flag VerifyAdapterCalls
• ... and 186 more: https://git.openjdk.org/jdk/compare/6e203384f8777fc55081065b128bd2b0ba074729...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@earthling-amzn, @ysramakrishna, @kdnilsen) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@rgithubli The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c333dc04)

[earthling-amzn]

This looks good to me. Someday we should look at combining some of the other related messages (free set status, e.g.) into ShenandoahHeap::print_heap_on.

[ysramakrishna]

[2.067s][debug][gc,heap ] GC(11) Heap After GC invocations=0 (full 0):

Looks like Shenandoah/GenShen are missing increment_total_collections(...), which updates the invocations=... part. I'd roughly expect it to equal the GC id (or be a tad smaller) GC(11).

[2.067s][debug][gc,heap ] GC(11) Shenandoah Heap
[2.067s][debug][gc,heap ] GC(11) 100M max, 100M soft max, 100M committed, 101356K used
[2.067s][debug][gc,heap ] GC(11) 400 x 256 K regions

A potential enhancement for GenShen would be to provide used region counts for old and young separately, and to add the "Generational" prefix in:

[2.067s][debug][gc,heap ] GC(11) Shenandoah Heap

Rest looks good, although I want to verify that we print along all gc cycles, not just concurrent ones, as seems to be the case here.

[ysramakrishna]

Left some comments in PR. Will complete review by EOD.

[earthling-amzn]

@ysramakrishna , good catch with increment_total_collections. The print_before and print_after calls surround the switch case that handles all GCs (conc, degen, full).

[ysramakrishna]

Reviewed; looks good, modulo earlier comments for additional information which might be useful for genshen.

[kdnilsen]

Thanks for this contribution. I concur with suggestions from @ysramakrishna.

[rgithubli]

Thanks all. Opened another JBS to fix the missing increment_total_collections in Shenandoah / GenShen, as well as to improve the GenShen logging: https://bugs.openjdk.org/browse/JDK-8364081

Keep this PR as it is and continue integrating this PR.

[rgithubli]

/integrate

[openjdk]

@rgithubli
Your change (at version c333dc0) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 4e53a9d.
Since your change was applied there have been 189 commits pushed to the master branch:

• 8477630: 8360679: Shenandoah: AOT saved adapter calls into broken GC barrier stub
• 2f1aed2: 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java
• 67e9328: 8363357: Remove unused flag VerifyAdapterCalls
• ... and 186 more: https://git.openjdk.org/jdk/compare/6e203384f8777fc55081065b128bd2b0ba074729...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @rgithubli Pushed as commit 4e53a9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.