Skip to content

8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb #26238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DingliZhang
Copy link
Member

@DingliZhang DingliZhang commented Jul 10, 2025

Hi all,
Please take a look and review this PR, thanks!

After JDK-8355293 , compiler/vectorization/runner/BasicIntOpTest.java failswith RVV but not Zvbb.
The reason for the error is that PopCountVI on RISC-V requires Zvbb, not just RVV.

Test

  • Run compiler/vectorization/runner/BasicIntOpTest.java on k1
  • Run compiler/vectorization/runner/BasicIntOpTest.java on qemu-system (enable RVV) w/ and w/o zvbb

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26238/head:pull/26238
$ git checkout pull/26238

Update a local copy of the PR:
$ git checkout pull/26238
$ git pull https://git.openjdk.org/jdk.git pull/26238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26238

View PR using the GUI difftool:
$ git pr show -t 26238

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26238.diff

Using Webrev

Link to Webrev Comment

…st.java fails when using RVV without using zvbb
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2025

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 73ab54e: 8360302: Update --release 25 symbol information for JDK 25 build 29
  • 80662a4: 8361499: Intersection type cast causes javac crash with -Xjcov
  • c118543: 8361704: Parallel: Simplify logic condition in MutableNUMASpace::initialize

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 10, 2025
@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@DingliZhang The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2025

Webrevs

@DingliZhang DingliZhang changed the title 8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails when using RVV without using zvbb [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb Jul 10, 2025
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jul 10, 2025
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks reasonable.

@DingliZhang DingliZhang changed the title [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb 8361829: [TESTBUG] RISC-V: compiler/vectorization/runner/BasicIntOpTest.java fails with RVV but not Zvbb Jul 10, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants