Skip to content

8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification #26227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bplb
Copy link
Member

@bplb bplb commented Jul 9, 2025

Hi all,

This pull request contains a backport of commit 6249259c from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 9 Jul 2025 and was reviewed by Alan Bateman and Chen Liang.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8361308 to be approved

Issues

  • JDK-8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification (Bug - P2)
  • JDK-8361308: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26227/head:pull/26227
$ git checkout pull/26227

Update a local copy of the PR:
$ git checkout pull/26227
$ git pull https://git.openjdk.org/jdk.git pull/26227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26227

View PR using the GUI difftool:
$ git pr show -t 26227

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26227.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2025

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification

Reviewed-by: liach, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jul 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2025

Webrevs

@bplb bplb changed the title 8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification Backport 6249259c8050f280fb1c489e816f09d5cd72a54b Jul 9, 2025
@openjdk openjdk bot changed the title Backport 6249259c8050f280fb1c489e816f09d5cd72a54b 8361299: (bf) CharBuffer.getChars(int,int,char[],int) violates pre-existing specification Jul 9, 2025
@openjdk
Copy link

openjdk bot commented Jul 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 9, 2025
@bplb
Copy link
Member Author

bplb commented Jul 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2025

Going to push as commit 9b99ed8.
Since your change was applied there has been 1 commit pushed to the jdk25 branch:

  • 532b1c7: 8360599: [TESTBUG] DumpThreadsWithEliminatedLock.java fails because of unstable inlining

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2025
@openjdk openjdk bot closed this Jul 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2025
@openjdk
Copy link

openjdk bot commented Jul 10, 2025

@bplb Pushed as commit 9b99ed8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants