8361726: Shenandoah: More detailed evacuation instrumentation

[earthling-amzn]

Shenandoah has not product instrumentation to track evacuation performance. This change introduces more detail by categorizing each evacuation as young, old or promotion.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361726: Shenandoah: More detailed evacuation instrumentation (Enhancement - P4)

Reviewers

• Kelvin Nilsen (@kdnilsen - Committer) 🔄 Re-review required (review applies to a741104a)
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer) 🔄 Re-review required (review applies to a741104a)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26222/head:pull/26222
$ git checkout pull/26222

Update a local copy of the PR:
$ git checkout pull/26222
$ git pull https://git.openjdk.org/jdk.git pull/26222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26222

View PR using the GUI difftool:
$ git pr show -t 26222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26222.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@earthling-amzn The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (cd69cd92)
• 02: Full - Incremental (23a86e36)
• 01: Full (e1f8c9b9)
• 00: Full (a741104a)

[kdnilsen]

Thanks. This instrumentation is helpful in evaluating further proposed changes.

[ysramakrishna]

Approved, modulo a few nits.

The extra detail is useful!

Shenandoah has product only instrumentation to track evacuation performance.

Did you mean to say non-product instead of product only above?

[openjdk]

@earthling-amzn this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout categorize-evacuations
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[ysramakrishna]

Instead of only the succeeding thread will end the evacuation, I might say: the unique thread that is successful will end the evacuation. (Alternatively, replace "succeeding" with "successful"; the word "succeeding" as an adjective can be ambiguous in this context.)

[earthling-amzn]

GHA failure on macos looks unrelated (test was running G1).

/integrate

[openjdk]

@earthling-amzn This pull request has not yet been marked as ready for integration.