-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8360312: Serviceability Agent tests fail with JFR enabled due to unknown thread type JfrRecorderThread #26198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8360312: Serviceability Agent tests fail with JFR enabled due to unknown thread type JfrRecorderThread #26198
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@plummercj The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a clean backport.
Thank you for the reviews Kevin and Serguei! /integrate |
Going to push as commit 9638050.
Your commit was automatically rebased without conflicts. |
@plummercj Pushed as commit 9638050. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8360312. The bug was introduced in JDK25 and fixed in JDK26, so should be backported to JDK25.
Tier5 ci testing in progress.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26198/head:pull/26198
$ git checkout pull/26198
Update a local copy of the PR:
$ git checkout pull/26198
$ git pull https://git.openjdk.org/jdk.git pull/26198/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26198
View PR using the GUI difftool:
$ git pr show -t 26198
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26198.diff
Using Webrev
Link to Webrev Comment