8342705: Add dark mode for docs #26185
Open
+610
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review an enhancement to add a dark theme to javadoc-generated API documentation. There is a new button in the top right corner that brings up a menu to switch between themes. Available options are "Light", "Dark", and "System Setting" (following the system-wide theme setting). The selected theme is stored and preserved across browser sessions.
Generated docs can be viewed here (
java.base
module only). The docs were generated with syntax highlighting enabled in order to view the highlighting themes, although that is obviously not part of the change.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26185/head:pull/26185
$ git checkout pull/26185
Update a local copy of the PR:
$ git checkout pull/26185
$ git pull https://git.openjdk.org/jdk.git pull/26185/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26185
View PR using the GUI difftool:
$ git pr show -t 26185
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26185.diff
Using Webrev
Link to Webrev Comment