-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361532: RISC-V: Several vector tests fail after JDK-8354383 #26178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into |
@DingliZhang This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @feilongjiang) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@DingliZhang The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Hi all,
Please take a look and review this PR, thanks!
After JDK-8354383 , several test cases fail when fastdebug with RVV.
The reason for the error is that riscv lacks CastVV with dst as the mask register.
This PR adds the corresponding matching rules.
Testing
qemu-system with RVV:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26178/head:pull/26178
$ git checkout pull/26178
Update a local copy of the PR:
$ git checkout pull/26178
$ git pull https://git.openjdk.org/jdk.git pull/26178/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26178
View PR using the GUI difftool:
$ git pr show -t 26178
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26178.diff
Using Webrev
Link to Webrev Comment