8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays

[dholmes-ora]

The original PR (#26123) had incorrect usage of SafeFetch32. This PR replaces that with the use of os::is_readable_range as proposed by @tstuefe (thank you!). In addition I found that code was no longer getting exercised by the regression test so I added a gtest for that (during which it was discovered that the new implementation in verify requires any gtest that uses it to be TEST_VM rather than TEST).

Testing: tiers 1-4

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays (Bug - P3)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)

Contributors

• Thomas Stuefe <stuefe@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26177/head:pull/26177
$ git checkout pull/26177

Update a local copy of the PR:
$ git checkout pull/26177
$ git pull https://git.openjdk.org/jdk.git pull/26177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26177

View PR using the GUI difftool:
$ git pr show -t 26177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26177.diff

Using Webrev

Link to Webrev Comment

[dholmes-ora]

/contributor add @tstuefe

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361447: [REDO] Checked version of JNI Release<type>ArrayElements needs to filter out known wrapped arrays

Co-authored-by: Thomas Stuefe <stuefe@openjdk.org>
Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 5205eae: 8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel
• bbc5c98: 8342868: Errors related to unused code on Windows after 8339120 in core libs
• 563a335: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage
• ... and 16 more: https://git.openjdk.org/jdk/compare/3bcbcc5747f9402796a1d9443d7a27d37acee9e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora
Contributor Thomas Stuefe <stuefe@openjdk.org> successfully added.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dholmes-ora]

@MBaesken please run this through your testing - thanks.

[mlbridge]

Webrevs

• 00: Full (87b5dd88)

[tstuefe]

This looks good to me. Thank you for considering my suggestions.

[dholmes-ora]

Thanks for the review @tstuefe !