Skip to content

8358679: [asan] vmTestbase/nsk/jvmti tests show memory issues #26176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexmenkov
Copy link

@alexmenkov alexmenkov commented Jul 8, 2025

The fix updates several tests ASAN complains about.
Tests for RawMonitors intentionally passes bad pointer to tested function, they should not be run with ASAN.
Test vmTestbase/nsk/jvmti/scenarios/events/EM07/em07t002 verifies COMPILED_METHOD_LOAD/COMPILED_METHOD_UNLOAD event and uses RawMonitor for synchronization. It destroys the monitor, but some events may arrive later (before VM exits). Usually JVMTI tests do not destroy synchronization monitors, removed destruction here.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358679: [asan] vmTestbase/nsk/jvmti tests show memory issues (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26176/head:pull/26176
$ git checkout pull/26176

Update a local copy of the PR:
$ git checkout pull/26176
$ git pull https://git.openjdk.org/jdk.git pull/26176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26176

View PR using the GUI difftool:
$ git pr show -t 26176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26176.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@alexmenkov The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 8, 2025
@alexmenkov alexmenkov changed the title fix 8358679 Jul 8, 2025
@openjdk openjdk bot changed the title 8358679 8358679: [asan] vmTestbase/nsk/jvmti tests show memory issues Jul 8, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2025

Webrevs

Comment on lines +40 to +41
* @comment the test intentionally passes bad argument to the function to verify the functionality,
it causes false positive from ASAN lib
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @comment the test intentionally passes bad argument to the function to verify the functionality,
it causes false positive from ASAN lib
* @comment The test intentionally passes a bad argument to the function to verify error checking,
which causes a false positive from the ASAN lib

Same comment for the other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants