-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361526: Synchronize ClassFile API verifier with hotspot #26174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice update, looks good to me.
The class file API verifier seems to be based off a version of hotspot verifier before Mar 3 2021. We are thus missing a few patches in the hotspot verifier:
JDK-8350029 JDK-8340110 JDK-8330606 JDK-8314295 JDK-8270398 JDK-8267118 JDK-8262368 JDK-8272096 JDK-8349923
Synchronization allows the ClassFile API verifier to catch up with upcoming verification changes for Valhalla strict fields as well.
Testing: select javac tests and classfile tests, running tier 1-3
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26174/head:pull/26174
$ git checkout pull/26174
Update a local copy of the PR:
$ git checkout pull/26174
$ git pull https://git.openjdk.org/jdk.git pull/26174/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26174
View PR using the GUI difftool:
$ git pr show -t 26174
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26174.diff
Using Webrev
Link to Webrev Comment