8360647: [XWayland] [OL10] NumPad keys are not triggered #26170
+25
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to pass
XK_KP_0
toNotifyKeyboardKeysym
in Remote Desktop API, it presses/releasesSHIFT
+XK_KP_Insert
.To get the same result as XTest api when using
NotifyKeyboardKeysym
we should useXK_KP_Insert
instead ofXK_KP_0
regardless of NumLock state. Similarly for other Numpad keys.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26170/head:pull/26170
$ git checkout pull/26170
Update a local copy of the PR:
$ git checkout pull/26170
$ git pull https://git.openjdk.org/jdk.git pull/26170/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26170
View PR using the GUI difftool:
$ git pr show -t 26170
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26170.diff
Using Webrev
Link to Webrev Comment