Skip to content

8360647: [XWayland] [OL10] NumPad keys are not triggered #26170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Jul 7, 2025

When we try to pass XK_KP_0 to NotifyKeyboardKeysym in Remote Desktop API, it presses/releases SHIFT + XK_KP_Insert.

To get the same result as XTest api when using NotifyKeyboardKeysym we should use XK_KP_Insert instead of XK_KP_0 regardless of NumLock state. Similarly for other Numpad keys.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360647: [XWayland] [OL10] NumPad keys are not triggered (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26170/head:pull/26170
$ git checkout pull/26170

Update a local copy of the PR:
$ git checkout pull/26170
$ git pull https://git.openjdk.org/jdk.git pull/26170/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26170

View PR using the GUI difftool:
$ git pr show -t 26170

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26170.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2025

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client client-libs-dev@openjdk.org rfr Pull request is ready for review labels Jul 7, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2025

Webrevs

@mrserb
Copy link
Member

mrserb commented Jul 8, 2025

To get the same result as XTest api when using NotifyKeyboardKeysym we should use XK_KP_Insert instead of XK_KP_0 regardless of NumLock state. Similarly for other Numpad keys.

Will Java receive the same keycodes if these events come from native code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants