Skip to content

Test 'javax/swing/JScrollPane/AcceleratedWheelScrolling/HorizScrollers.java' failed on Windows 2025 x64 because there is a failure frame while the test case is running #26165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

DamonGuy
Copy link
Contributor

@DamonGuy DamonGuy commented Jul 7, 2025

This test only fails in the automated portion on Windows with Nimbus LAF. The failure message is always that the leading cell is not aligned, but I see no obvious issues with the UI when testing myself. The test fails in older JDK versions as well. The original test relies on applet and cannot be run exactly, but this test was previously converted to remove all applet usage in JDK-8354695. Since this test still fails on older JDKs and is not a regression, I chose to skip the test specifically for Nimbus LAF. I suspect this is better than ProblemListing the test for Windows since the test only fails on Windows if Nimbus LAF is used.

I also removed the automated failing of the test to allow the user to see the failure message before the test closes. Test instructions are updated to align with this.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26165/head:pull/26165
$ git checkout pull/26165

Update a local copy of the PR:
$ git checkout pull/26165
$ git pull https://git.openjdk.org/jdk.git pull/26165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26165

View PR using the GUI difftool:
$ git pr show -t 26165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26165.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2025

👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@DamonGuy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 7, 2025
@prsadhuk
Copy link
Contributor

prsadhuk commented Jul 8, 2025

What exactly is the failure thrown in Nimbus L&F? JBS says PassFailJFrame.forceFail is called
From my running it seems the failure is "java.lang.RuntimeException: leading cell is not aligned"
It can be a genuine issue for Nimbus since it behaves ok for other L&F..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants