Skip to content

8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given #26163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jul 7, 2025

Hi all,

This pull request contains a backport of commit 3525a40f from the openjdk/jdk repository.

The commit being backported was authored by Archie Cobbs on 27 Jun 2025 and was reviewed by Maurizio Cimadamore and Uwe Schindler.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8359844 to be approved

Issues

  • JDK-8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given (Bug - P2)
  • JDK-8359844: Behavior change when both -Xlint:options and -Xlint:-options flags are given (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26163/head:pull/26163
$ git checkout pull/26163

Update a local copy of the PR:
$ git checkout pull/26163
$ git pull https://git.openjdk.org/jdk.git pull/26163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26163

View PR using the GUI difftool:
$ git pr show -t 26163

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26163.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2025

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3525a40f39a966b8592f694a9b3cd4c5dc449266 8359596: Behavior change when both -Xlint:options and -Xlint:-options flags are given Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jul 7, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2025
@lahodaj
Copy link
Contributor Author

lahodaj commented Jul 8, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 8, 2025

Going to push as commit 5e716fd.
Since your change was applied there has been 1 commit pushed to the jdk25 branch:

  • 3e93b98: 8354872: Clarify java.lang.Process resource cleanup

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 8, 2025
@openjdk openjdk bot closed this Jul 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 8, 2025
@openjdk
Copy link

openjdk bot commented Jul 8, 2025

@lahodaj Pushed as commit 5e716fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean compiler compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants