Skip to content

8361349: Fix visibility of CollectedHeap::stop() and ::print_tracing_info() #26160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

8361349: Fix visibility of CollectedHeap::stop() and ::print_tracing_info() #26160

wants to merge 3 commits into from
+27 −25

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Jul 7, 2025 •
edited by openjdk bot
Loading

Hi all,

please review this refactoring to improve the visibility of CollectedHeap::stop() and CH::print_tracing_info().

The change moves these methods to protected visibility.

Testing: gha

Thanks,
Thomas

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361349: Fix visibility of CollectedHeap::stop() and ::print_tracing_info() (Enhancement - P4)

Reviewers

Reviewers without OpenJDK IDs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26160/head:pull/26160
$ git checkout pull/26160

Update a local copy of the PR:
$ git checkout pull/26160
$ git pull https://git.openjdk.org/jdk.git pull/26160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26160

View PR using the GUI difftool:
$ git pr show -t 26160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26160.diff

Using Webrev

Link to Webrev Comment

@tschatzl
8361349
d601eb4 
Hi all,

  please review this refactoring to improve the visibility of `CollectedHeap::stop()` and `CH::print_tracing_info()`.

The change moves these methods to `protected` visibility.

Testing: gha

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 7, 2025

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 7, 2025 •
edited
Loading

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361349: Fix visibility of CollectedHeap::stop() and ::print_tracing_info()

Reviewed-by: iwalulya, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8361349 8361349: Fix visibility of CollectedHeap::stop() and ::print_tracing_info() Jul 7, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 7, 2025
@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@tschatzl The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Jul 7, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 7, 2025 •
edited
Loading

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2025
@tschatzl
* iwalulya suggested to make leaf classes use private; although proba…
5fd5d6f 
…bly one wants to use final, but Hotspot does not seem to use that
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 7, 2025
walulyai
walulyai approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

src/hotspot/share/gc/epsilon/epsilonHeap.hpp Outdated
@@ -49,6 +49,10 @@ class EpsilonHeap : public CollectedHeap {
volatile size_t _last_counter_update;
volatile size_t _last_heap_print;

private:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private: can be removed.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 7, 2025
walulyai
walulyai approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@walulyai walulyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertnetymk albertnetymk albertnetymk approved these changes

@walulyai walulyai walulyai approved these changes

@abdelhak-zaaim abdelhak-zaaim abdelhak-zaaim approved these changes

Assignees
No one assigned
Labels
hotspot-gc hotspot-gc-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review shenandoah shenandoah-dev@openjdk.org
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tschatzl @albertnetymk @walulyai @abdelhak-zaaim