Skip to content

8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError #26122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

8356942: invokeinterface Throws AbstractMethodError Instead of IncompatibleClassChangeError #26122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13744cd
8356942: invokeinterface Throws AbstractMethodError Instead of Incomp…
dholmes-ora Jul 3, 2025
5e49c49
regression test
dholmes-ora Jul 3, 2025
2988354
Replaced new test by updating existing defmeth case that was missing …
dholmes-ora Jul 8, 2025
d12213e
Fix weird logic - requested by Coleen
dholmes-ora Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 38 additions & 36 deletions src/hotspot/share/oops/klassVtable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,38 +1180,42 @@ void klassItable::check_constraints(GrowableArray<Method*>* supers, TRAPS) {
Method* interface_method = supers->at(i); // method overridden

if (target != nullptr && interface_method != nullptr) {
InstanceKlass* method_holder = target->method_holder();
InstanceKlass* interf = interface_method->method_holder();
HandleMark hm(THREAD);
Handle method_holder_loader(THREAD, method_holder->class_loader());
Handle interface_loader(THREAD, interf->class_loader());

if (method_holder_loader() != interface_loader()) {
ResourceMark rm(THREAD);
Symbol* failed_type_symbol =
SystemDictionary::check_signature_loaders(target->signature(),
_klass,
method_holder_loader,
interface_loader,
true);
if (failed_type_symbol != nullptr) {
stringStream ss;
ss.print("loader constraint violation in interface itable"
" initialization for class %s: when selecting method '",
_klass->external_name());
interface_method->print_external_name(&ss),
ss.print("' the class loader %s for super interface %s, and the class"
" loader %s of the selected method's %s, %s have"
" different Class objects for the type %s used in the signature (%s; %s)",
interf->class_loader_data()->loader_name_and_id(),
interf->external_name(),
method_holder->class_loader_data()->loader_name_and_id(),
method_holder->external_kind(),
method_holder->external_name(),
failed_type_symbol->as_klass_external_name(),
interf->class_in_module_of_loader(false, true),
method_holder->class_in_module_of_loader(false, true));
THROW_MSG(vmSymbols::java_lang_LinkageError(), ss.as_string());
// Do not check loader constraints for overpass methods because overpass
// methods are created by the jvm to throw exceptions.
if (!target->is_overpass()) {
InstanceKlass* method_holder = target->method_holder();
InstanceKlass* interf = interface_method->method_holder();
HandleMark hm(THREAD);
Handle method_holder_loader(THREAD, method_holder->class_loader());
Handle interface_loader(THREAD, interf->class_loader());

if (method_holder_loader() != interface_loader()) {
ResourceMark rm(THREAD);
Symbol* failed_type_symbol =
SystemDictionary::check_signature_loaders(target->signature(),
_klass,
method_holder_loader,
interface_loader,
true);
if (failed_type_symbol != nullptr) {
stringStream ss;
ss.print("loader constraint violation in interface itable"
" initialization for class %s: when selecting method '",
_klass->external_name());
interface_method->print_external_name(&ss),
ss.print("' the class loader %s for super interface %s, and the class"
" loader %s of the selected method's %s, %s have"
" different Class objects for the type %s used in the signature (%s; %s)",
interf->class_loader_data()->loader_name_and_id(),
interf->external_name(),
method_holder->class_loader_data()->loader_name_and_id(),
method_holder->external_kind(),
method_holder->external_name(),
failed_type_symbol->as_klass_external_name(),
interf->class_in_module_of_loader(false, true),
method_holder->class_in_module_of_loader(false, true));
THROW_MSG(vmSymbols::java_lang_LinkageError(), ss.as_string());
}
}
}
}
Expand Down Expand Up @@ -1333,11 +1337,9 @@ void klassItable::initialize_itable_for_interface(int method_table_offset, Insta
target = LinkResolver::lookup_instance_method_in_klasses(_klass, m->name(), m->signature(),
Klass::PrivateLookupMode::skip);
}
if (target == nullptr || !target->is_public() || target->is_abstract() || target->is_overpass()) {
assert(target == nullptr || !target->is_overpass() || target->is_public(),
"Non-public overpass method!");
if (target == nullptr || !target->is_public() || target->is_abstract()) {
// Entry does not resolve. Leave it empty for AbstractMethodError or other error.
if (!(target == nullptr) && !target->is_public()) {
if (target != nullptr && !target->is_public()) {
// Stuff an IllegalAccessError throwing method in there instead.
itableOffsetEntry::method_entry(_klass, method_table_offset)[m->itable_index()].
initialize(_klass, Universe::throw_illegal_access_error());
Expand Down
54 changes: 31 additions & 23 deletions test/hotspot/jtreg/vmTestbase/vm/runtime/defmeth/ConflictingDefaultsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ public static void main(String[] args) {
* class C implements I, J {}
*
* TEST: C c = new C(); c.m() ==> ICCE
* TEST: I c = new C(); c.m() ==> ICCE
* TEST: J c = new C(); c.m() ==> ICCE
*/
public void testConflict(TestBuilder b) {
Interface I = b.intf("I")
Expand All @@ -95,7 +97,13 @@ public void testConflict(TestBuilder b) {
ConcreteClass C = b.clazz("C").implement(I,J).build();

b.test().callSite(C, C, "m","()I")
.throws_(IncompatibleClassChangeError.class)
.throwsExact(IncompatibleClassChangeError.class)
.done()
.test().callSite(I, C, "m","()I")
.throwsExact(IncompatibleClassChangeError.class)
.done()
.test().callSite(J, C, "m","()I")
.throwsExact(IncompatibleClassChangeError.class)
.done();
}

Expand Down Expand Up @@ -145,7 +153,7 @@ public void testReabstract(TestBuilder b) {
ConcreteClass C = b.clazz("C").implement(J).build();

b.test().callSite(C, C, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done();
}

Expand Down Expand Up @@ -177,16 +185,16 @@ public void testReabstract2(TestBuilder b) {
.build();

b.test().callSite(C, C, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done()
.test().callSite(J, C, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done()
.test().callSite(I, C, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done()
.test().callSite(D, D, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done();
}

Expand Down Expand Up @@ -218,7 +226,7 @@ public void testReabstractConflictingDefaults(TestBuilder b) {
ConcreteClass C = b.clazz("C").extend(A).implement(K).build();

b.test().callSite(A, C, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done();
}

Expand Down Expand Up @@ -259,13 +267,13 @@ public void testReabstractConflictingDefaultsInvokeInterface(TestBuilder b) {
ConcreteClass D = b.clazz("D").extend(C).implement(L).build();

b.test().callSite(I, A, "m","()I")
.throws_(IncompatibleClassChangeError.class)
.throwsExact(IncompatibleClassChangeError.class)
.done()
.test().callSite(K, C, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done()
.test().callSite(L, D, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done();
}

Expand Down Expand Up @@ -307,10 +315,10 @@ public void testReabstractConflictingDefaultsSuper(TestBuilder b) {
.build();

b.test().callSite(I, A, "m","()I")
.throws_(IncompatibleClassChangeError.class)
.throwsExact(IncompatibleClassChangeError.class)
.done()
.test().callSite(L, D, "m","()I")
.throws_(AbstractMethodError.class)
.throwsExact(AbstractMethodError.class)
.done();
}

Expand Down Expand Up @@ -370,22 +378,22 @@ public void testReabstractResolveMethod00705m2(TestBuilder b) {
}

b.test().callSite(A, C, "m", "()I")
.throws_(expectedError2)
.throwsExact(expectedError2)
.done()
.test().callSite(C, C, "m", "()I")
.throws_(expectedError2)
.throwsExact(expectedError2)
.done()
.test().callSite(J, C, "m", "()I")
.throws_(expectedError1)
.throwsExact(expectedError1)
.done()
.test().callSite(I, C, "m", "()I")
.throws_(expectedError1)
.throwsExact(expectedError1)
.done()
.test().callSite(C, C, "test_Cmethod_ISMR", "()V")
.throws_(expectedError2)
.throwsExact(expectedError2)
.done()
.test().callSite(A, C, "test_Amethod_ISIMR", "()V")
.throws_(expectedError2)
.throwsExact(expectedError2)
.done();
}

Expand Down Expand Up @@ -486,13 +494,13 @@ public void testMixedArity1(TestBuilder b) {
.test()
.callSite(I, C, "m","(I)I")
.params(0)
.throws_(NoSuchMethodError.class)
.throwsExact(NoSuchMethodError.class)
.done()

// J j = new C(); ...
.test()
.callSite(J, C, "m","()I")
.throws_(NoSuchMethodError.class)
.throwsExact(NoSuchMethodError.class)
.done()
.test()
.callSite(J, C, "m","(I)I")
Expand Down Expand Up @@ -539,19 +547,19 @@ public void testMixedArity2(TestBuilder b) {
// I i = new C(); ...
b.test()
.callSite(I, C, "m","()I")
.throws_(IncompatibleClassChangeError.class)
.throwsExact(IncompatibleClassChangeError.class)
.done()

// J j = new C(); ...
.test()
.callSite(J, C, "m","()I")
.throws_(IncompatibleClassChangeError.class)
.throwsExact(IncompatibleClassChangeError.class)
.done()

// C c = new C(); ...
.test()
.callSite(C, C, "m","()I")
.throws_(IncompatibleClassChangeError.class)
.throwsExact(IncompatibleClassChangeError.class)
.done()
.test()
.callSite(C, C, "m","(I)I")
Expand Down