Skip to content

8360037: Refactor ImageReader in preparation for Valhalla support #26054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: pr/26044
Choose a base branch
from
+1,900 −615
Open

8360037: Refactor ImageReader in preparation for Valhalla support #26054

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6fb20c8
Reapply diffs.
david-beaumont Jun 12, 2025
37642fe
WIP - more tests needed.
david-beaumont Jun 18, 2025
3593140
Pretty much ready for review now.
david-beaumont Jun 27, 2025
2f7e175
Newline at EOF.
david-beaumont Jun 27, 2025
cef0a62
syncing to main branch
david-beaumont Jun 28, 2025
e551c3e
undo dependent changes
david-beaumont Jun 28, 2025
1ba3370
Merge branch 'master' into jdk_8355953_reader/squashed
david-beaumont Jun 28, 2025
d8efaa0
Integrating with ImageReaderBenchmark.
david-beaumont Jun 30, 2025
29633a1
Updates based on feedback.
david-beaumont Jul 1, 2025
9d9e62b
Feedback changes.
david-beaumont Jul 1, 2025
a8b68c7
Small feedback related tweaks.
david-beaumont Jul 2, 2025
df1705c
Feedback related changes.
david-beaumont Jul 2, 2025
4330357
Make image file attributes non-lazy (simpler code). Plus minor tweaks…
david-beaumont Jul 11, 2025
bb9972d
Linting of a few minor issues (nothing serious).
david-beaumont Jul 11, 2025
92a7eb6
Feedback changes.
david-beaumont Jul 15, 2025
332a1c8
Feedback changes.
david-beaumont Jul 15, 2025
5ca0a14
Dealing with remaining review comments.
david-beaumont Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions make/test/BuildMicrobenchmark.gmk
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this file, it's part of the PR to add the benchmark. I'll merge and sort everything out once that's in.

Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ $(eval $(call SetupJavaCompilation, BUILD_JDK_MICROBENCHMARK, \
--add-exports java.base/jdk.internal.classfile.impl=ALL-UNNAMED \
--add-exports java.base/jdk.internal.event=ALL-UNNAMED \
--add-exports java.base/jdk.internal.foreign=ALL-UNNAMED \
--add-exports java.base/jdk.internal.jimage=ALL-UNNAMED \
--add-exports java.base/jdk.internal.misc=ALL-UNNAMED \
--add-exports java.base/jdk.internal.util=ALL-UNNAMED \
--add-exports java.base/jdk.internal.vm=ALL-UNNAMED \
Expand Down
Loading