-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8341735: Rewrite the build/AbsPathsInImage.java test to not load the entire file at once #26030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@cost0much The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Sorry for the potentially stupid question but: what happens if the pattern spans a chunk? |
These changes should prevent entire binary files from being loaded into memory for build/AbsPathsInImage.java test. I chose a default buffer size of 8KB since BufferedInputStream uses that, but open to alternative solutions. GHA passes and test passes on linux x64.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26030/head:pull/26030
$ git checkout pull/26030
Update a local copy of the PR:
$ git checkout pull/26030
$ git pull https://git.openjdk.org/jdk.git pull/26030/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26030
View PR using the GUI difftool:
$ git pr show -t 26030
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26030.diff
Using Webrev
Link to Webrev Comment