8344159: Add lint warnings for unnecessary warning suppression #25167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra checks for "-Xlint:none" are needed now because of JDK-8352612, which changed the behavior of "-Xlint:none" to no longer imply "-nowarn", which allowed the affected warnings to get away with skipping that check.
|
@archiecobbs This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@archiecobbs The pull request is being re-evaluated and the inactivity timeout has been reset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for warning about
@SuppressWarningsannotations that are unnecessary because they don't actually suppress any warnings.The JDK itself contains 400+ instances of unnecessary
@SuppressWarningsannotations. The relevant build files have been updated accordingly to include the-Xlint:-suppressioncompiler flag.Summary of changes:
@SuppressWarningsannotations that don't actually suppress any warnings and a new lint categorysuppressionthat includes it (default disabled)Log.warning()to automatically validate any current suppression of the warning's lint categoryLint.isEnabled()andLint.isSuppressed()with parameterboolean validateto optionally also validate any applicable suppressionLint.isActive()to test whether a category is enabled or suppression of the category is being trackedLintMapperto keep track of which suppressions are validated and (later) warn about those that never are*.gmkbuild files to suppresssuppressionwarnings so that building with-Werrorstill worksPrerequisites to this PR:
Progress
Warning
6723459: javac to flag where warning suppression is not requiredIssues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25167/head:pull/25167$ git checkout pull/25167Update a local copy of the PR:
$ git checkout pull/25167$ git pull https://git.openjdk.org/jdk.git pull/25167/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25167View PR using the GUI difftool:
$ git pr show -t 25167Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25167.diff