Skip to content

8356266: Fix non-Shenandoah build after JDK-8356075 #25064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented May 6, 2025

JDK-8356075 (see PR #25001) causes builds without Shenandoah GC to fail. It's missing an #if INCLUDE_SHENANDOAHGC.

Testing:

  • Build without Shenandoah GC

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8356266: Fix non-Shenandoah build after JDK-8356075 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25064/head:pull/25064
$ git checkout pull/25064

Update a local copy of the PR:
$ git checkout pull/25064
$ git pull https://git.openjdk.org/jdk.git pull/25064/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25064

View PR using the GUI difftool:
$ git pr show -t 25064

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25064.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2025

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 6, 2025

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356266: Fix non-Shenandoah build after JDK-8356075

Reviewed-by: dnsimon, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 6, 2025
@openjdk
Copy link

openjdk bot commented May 6, 2025

@rkennke The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels May 6, 2025
@mlbridge
Copy link

mlbridge bot commented May 6, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 6, 2025
@rkennke
Copy link
Contributor Author

rkennke commented May 6, 2025

Thanks, @dougxc! Is this trivial? Can I push this right away to fix the build?

@rkennke
Copy link
Contributor Author

rkennke commented May 6, 2025

Some GHA failures - they look unrelated.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes. Trivial.

@rkennke
Copy link
Contributor Author

rkennke commented May 6, 2025

Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented May 6, 2025

Going to push as commit bfdafb7.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 6, 2025
@openjdk openjdk bot closed this May 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2025
@openjdk
Copy link

openjdk bot commented May 6, 2025

@rkennke Pushed as commit bfdafb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants