-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8355536: Create version constants to model preview language and vm features #25017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Tested tier 1-2, no failure, so this isn't creating breakage. Marking this RFR. |
|
src/java.base/share/classes/java/lang/reflect/ClassFileFormatVersion.java
Outdated
Show resolved
Hide resolved
src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Luca Kellermann <lukellmann@gmail.com>
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout feature/preview-cffv
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@liach this pull request can not be integrated into git checkout feature/preview-cffv
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
Sometimes, for version-specific feature access APIs, we wish to access the preview features of the current Java SE release. To reduce the impact of adding one preview-specific version on every site, we can add a constant modeling the preview features as a fake version.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25017/head:pull/25017
$ git checkout pull/25017
Update a local copy of the PR:
$ git checkout pull/25017
$ git pull https://git.openjdk.org/jdk.git pull/25017/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25017
View PR using the GUI difftool:
$ git pr show -t 25017
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25017.diff
Using Webrev
Link to Webrev Comment