8355353: File Leak in os::read_image_release_file of os.cpp:1552

[coleenp]

Simple change to close an opened file.
Tested with tier1-4.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355353: File Leak in os::read_image_release_file of os.cpp:1552 (Bug - P3)

Reviewers

• Zhengyu Gu (@zhengyu123 - Reviewer)
• Johan Sjölen (@jdksjolen - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25012/head:pull/25012
$ git checkout pull/25012

Update a local copy of the PR:
$ git checkout pull/25012
$ git pull https://git.openjdk.org/jdk.git pull/25012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25012

View PR using the GUI difftool:
$ git pr show -t 25012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25012.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355353: File Leak in os::read_image_release_file of os.cpp:1552

Reviewed-by: zgu, jsjolen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 114 new commits pushed to the master branch:

• 03f0ec4: 8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java
• 4d2d129: 8355962: RISCV64 cross build fails after 8354996
• 56468c4: 8322810: Lambda expression types can't be classes
• ... and 111 more: https://git.openjdk.org/jdk/compare/4b880299881c9413038d647123e3b658999c6f8f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (eda56036)

[zhengyu123]

LGTM

[coleenp]

Thanks Zhengyu.

[coleenp]

Thanks for the reviews Johan and Zhengyu.
/integrate

[openjdk]

Going to push as commit a8cd01f.
Since your change was applied there have been 125 commits pushed to the master branch:

• 0264797: 8352730: RISC-V: Disable tests in qemu-user
• f1e06c3: 8299934: LocalExecutionControl replaces default uncaught exception handler
• 6dd5553: 8354329: Rewrite runtime/ClassFile/JsrRewriting.java and OomWhileParsingRepeatedJsr.java tests
• ... and 122 more: https://git.openjdk.org/jdk/compare/4b880299881c9413038d647123e3b658999c6f8f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit a8cd01f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.