8348611: Eliminate DeferredLintHandler and emit warnings after attribution

[archiecobbs]

This is a cleanup/refactoring of how lint warnings are logged and @SuppressWarnings annotations applied.

A central challenge with lint warnings is that warnings can be generated during any compiler phase, but whether a particular lint warning is suppressed via @SuppressWarnings can't be known until after attribution. For example, the parser doesn't have enough information to interpret and apply @SuppressWarnings("text-blocks") to text blocks, or @SuppressWarnings("preview") to preview lexical features; instead, the DeferredLintHandler is used to workaround this limitation.

In addition, several other factors complicate things:

• Knowing the current applicable Lint instance requires manually tracking it with each declaration visited and applying/removing the @SuppressWarnings annotation there, if any
• Some warnings are "suppressibly mandatory" (i.e., they are emitted if not suppressed instead of emitted if enabled)
• Some warnings are "unsuppressibly mandatory" (e.g., the "internal proprietary API" warning)
• Some mandatory warnings are aggregated into notes that are emitted at the end of compilation when not enabled
• Some warnings are lint warnings, with a corresponding lint category, while others are just "plain" warnings
• Some lint warnings are suppressible via @SuppressWarnings, while others are only suppressible via -Xlint:-foo flags
• Speculative compilation requires holding log messages in purgatory until the speculation resolves, after which they are then either discarded or emitted. But this creates a tricky interaction with DeferredLintHandler because even after speculation is complete, we may still not yet know whether a warning should be suppressed.

Previously the logic to get all of this right was non-obviously woven around the code base. In particular, you needed to know somehow whether or not to use DeferredLintHandler, and in what "mode".

The overall goal of this PR is to simplify usage so that no matter where you are in the compiler, you can just invoke log.warning() to log a warning and (mostly) forget about all of the details listed above.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8348611: Eliminate DeferredLintHandler and emit warnings after attribution (Enhancement - P5)
• JDK-8224228: No way to locally suppress lint warnings in parser/tokenizer or preview features (Task - P4)
• JDK-8353758: Missing calls to Log.useSource() in JavacTrees (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24584/head:pull/24584
$ git checkout pull/24584

Update a local copy of the PR:
$ git checkout pull/24584
$ git pull https://git.openjdk.org/jdk.git pull/24584/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24584

View PR using the GUI difftool:
$ git pr show -t 24584

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24584.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@archiecobbs this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8348611
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @archiecobbs This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[archiecobbs]

/issue remove JDK-8350514

[openjdk]

@archiecobbs
Removing additional issue from issue list: 8350514.

[mlbridge]

Webrevs

• 00: Full (ec02990a)