Skip to content

[MainUI] Semantics picker #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented May 1, 2025

This PR changes the semantics picker to use a treeview.

This treeview is inherited from #3165 and enhanced (and this PR does include all changes from this previous PR as well). It therefore also introduces some enhancements in the semantic treeview maintenance.

The semantics treeview presents a searchable treeview of the semantic classes/properties, limited to what is relevant in the context. When used as a picker, radio buttons are used for picking. It has filter and expand capabilities, options to show the semantic name and synonyms and tooltips showing the semantic descriptions if available.

This PR can be review after #3165 (in which case I will rebase this one when done), or can be reviewed completely to cover both semantics maintenance and semantics picker. If this is the preference, I will rename this PR and close the previous one. @florian-h05 Please advise.

@jimtng @andrewfg @lolodomo FYI

SemanticsPicker

mherwege added 4 commits May 1, 2025 18:11
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested review from ghys and florian-h05 as code owners May 1, 2025 16:29
Copy link

relativeci bot commented May 1, 2025

#3090 Bundle Size — 11.24MiB (+0.4%).

9e5693c(current) vs efe3fef main#3073(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 7 changes Regression 2 regressions
                 Current
#3090
     Baseline
#3073
Regression  Initial JS 2.01MiB(+0.05%) 2MiB
No change  Initial CSS 577.53KiB 577.53KiB
Change  Cache Invalidation 19.16% 18%
Change  Chunks 252(+0.8%) 250
Change  Assets 275(+0.73%) 273
Change  Modules 3001(+0.87%) 2975
Regression  Duplicate Modules 161(+6.62%) 151
Change  Duplicate Code 1.79%(+2.87%) 1.74%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#3090
     Baseline
#3073
Regression  JS 9.44MiB (+0.45%) 9.4MiB
Regression  CSS 871.12KiB (+0.28%) 868.72KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.38KiB 1.38KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:semantics_pickerProject dashboard


Generated by RelativeCIDocumentationReport issue

@jimtng
Copy link
Contributor

jimtng commented May 1, 2025

Beautiful!

@mherwege mherwege changed the title Semantics picker [MainUI] Semantics picker May 1, 2025
mherwege added 4 commits May 2, 2025 12:10
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@florian-h05 florian-h05 added main ui Main UI enhancement New feature or request awaiting other PR Depends on another PR labels May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting other PR Depends on another PR enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants