-
-
Notifications
You must be signed in to change notification settings - Fork 256
[MainUI] Semantics picker #3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mherwege
wants to merge
8
commits into
openhab:main
Choose a base branch
from
mherwege:semantics_picker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
#3090 Bundle Size — 11.24MiB (+0.4%).9e5693c(current) vs efe3fef main#3073(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch mherwege:semantics_picker Project dashboard Generated by RelativeCI Documentation Report issue |
Beautiful! |
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the semantics picker to use a treeview.
This treeview is inherited from #3165 and enhanced (and this PR does include all changes from this previous PR as well). It therefore also introduces some enhancements in the semantic treeview maintenance.
The semantics treeview presents a searchable treeview of the semantic classes/properties, limited to what is relevant in the context. When used as a picker, radio buttons are used for picking. It has filter and expand capabilities, options to show the semantic name and synonyms and tooltips showing the semantic descriptions if available.
This PR can be review after #3165 (in which case I will rebase this one when done), or can be reviewed completely to cover both semantics maintenance and semantics picker. If this is the preference, I will rename this PR and close the previous one. @florian-h05 Please advise.
@jimtng @andrewfg @lolodomo FYI