Add Matter metadata #3129
Merged
Add Matter metadata #3129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
6 tasks
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
#3171 Bundle Size — 11.26MiB (+0.13%).20d839f(current) vs 60d7f8c main#3157(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #3171 |
Baseline #3157 |
|
|---|---|---|
 Initial JS |
2.01MiB |
2.01MiB |
| Initial CSS |
577.53KiB |
577.53KiB |
 Cache Invalidation |
18.8% |
18.71% |
| Chunks |
251 |
251 |
| Assets |
274 |
274 |
| Modules |
2992(+0.13%) |
2988 |
| Duplicate Modules |
148 |
148 |
| Duplicate Code |
1.69% |
1.69% |
| Packages |
97 |
97 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current #3171 |
Baseline #3157 |
|
|---|---|---|
| JS |
9.47MiB (+0.15%) |
9.46MiB |
| CSS |
870.07KiB |
870.07KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.38KiB |
1.38KiB |
| Other |
871B |
871B |
Bundle analysis report Branch digitaldan:matter-metadata Project dashboard
Generated by RelativeCI Documentation Report issue
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Hi, @florian-h05 this is ready for review when you get the chance, thanks! |
|
I’ve just started reviewing the binding PR, hope I can finish it today (had to leave my keyboard for now). |
|
Thanks! No worries if not today ;-) |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
…imal values Stepsize is 0.01. Signed-off-by: Florian Hotze <dev@florianhotze.com>
Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
approved these changes
May 28, 2025
|
Thanks @florian-h05 for the additions and review! LGTM |
|
Congrats all around! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the upcoming Matter binding. I'm posting a bit early for visibility, still need to test this quite a bit.
See openhab/openhab-addons#18486