Skip to content

Include source with item event descriptions when present #5080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Include source with item event descriptions when present #5080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ....openhab.core/src/main/java/org/openhab/core/items/events/GroupItemStateChangedEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ public String getType() {

@Override
public String toString() {
return String.format("%s through %s", super.toString(), memberName);
String result = String.format("%s through %s", super.toString(), memberName);
String source = getSource();
if (source != null) {
result = String.format("%s (source: %s)", result, source);
}
return result;
}
}
7 changes: 6 additions & 1 deletion bundles/org.openhab.core/src/main/java/org/openhab/core/items/events/ItemCommandEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ public Command getItemCommand() {

@Override
public String toString() {
return String.format("Item '%s' received command %s", itemName, command);
String result = String.format("Item '%s' received command %s", itemName, command);
String source = getSource();
if (source != null) {
result = String.format("%s (source: %s)", result, source);
}
return result;
}
}
7 changes: 6 additions & 1 deletion ...s/org.openhab.core/src/main/java/org/openhab/core/items/events/ItemStateChangedEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ public State getOldItemState() {

@Override
public String toString() {
return String.format("Item '%s' changed from %s to %s", itemName, oldItemState, itemState);
String result = String.format("Item '%s' changed from %s to %s", itemName, oldItemState, itemState);
String source = getSource();
if (source != null) {
result = String.format("%s (source: %s)", result, source);
}
return result;
}
}