Skip to content

Revert "Upgrade JUnit to 5.12.1 (#4642)" #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented May 5, 2025

  • This reverts commit 8de8b4d.
  • Add note about itests not being executed with junit 5.12.

See discussion in #4642 (comment).

@holgerfriedrich holgerfriedrich added bug An unexpected problem or unintended behavior of the Core regression labels May 5, 2025
@holgerfriedrich holgerfriedrich requested a review from wborn May 5, 2025 18:34
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner May 5, 2025 18:34
* This reverts commit 8de8b4d.
* Add note about itests not being executed with junit 5.12.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's better to revert it for now.

@wborn wborn merged commit 8eb6eea into openhab:main May 7, 2025
4 checks passed
@wborn wborn added this to the 5.0 milestone May 7, 2025
@holgerfriedrich holgerfriedrich deleted the pr-revert-junit512 branch May 7, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants