Semantic tags: Apply description texts for Point/Property/Equipment

[andrewfg]

Relates to #4746

Pinging @mherwege / @jimtng / @jlaur

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

[jimtng]

Thanks for the massive work done here.

A few comments:

• I think that all the "Related to ..." are too vague and should just be removed.
• Sentence casing or Title Casing?
• @merwege, do you think that when the description is the same as the label, we should just not set a description here, and in the UI it can do something like description || label ?

[andrewfg]

all the "Related to ..." are too vague and should just be removed.

OK

Sentence casing or Title Casing?

Sentence

do you think that when the description is the same as the label, we should just not set a description here, and in the UI it can do something like description || label ?

It shows the label anyway. And the description underneath. So it's Ok to leave the description blank (which therefore just leaves an empty line)..

[mherwege]

It shows the label anyway. And the description underneath. So it's Ok to leave the description blank (which therefore just leaves an empty line)..

At the moment, it does not show it in the semantic picker. I was intending to make it a tooltip. This would allow longer, more descriptive, text. The label is also not shown at the moment. This should be short and can be multiple words. I intend to (optionally) show these. The only thing shown is the name.

[mherwege]

• @mherwege, do you think that when the description is the same as the label, we should just not set a description here, and in the UI it can do something like description || label ?

My intention was to use a tooltip and show a tooltip icon when there is a description available. I see this as help for the user to choose the right category. Look at the existing longer text for Indoor.

[mherwege]

I wouldn’t include a description if it is the same as the label or one of the synonyms. That doesn’t add value and I would rather have it to clarify usage.

[andrewfg]

Based on the above feedbacks, I shall end up stripping away most of the applied description texts again.

[mherwege]

Based on the above feedbacks, I shall end up stripping away most of the applied description texts again.

Sorry about that. I appreciate all your effort on this.

[andrewfg]

:)

[andrewfg]

@mherwege I resolved the merge conflict, so I think it would be good to actually merge this asap (before someone comes up with any other new tags)

[mherwege]

Is DefaultSemanticTags.java generated, or does it need to be reviewed separately as well?

[mherwege]

LGTM after the 2 remarks I made.

[andrewfg]

Is DefaultSemanticTags.java generated, or does it need to be reviewed separately as well?

It is generated. So not required to be reviewed.

[holgerfriedrich]

@andrewfg could you pls rebase and re-run the generator?
Thanks!

btw: do you know if installing with profile -Pgenerate-tag-classes should work with Windows? I have some issues getting the generator to work in Windows? Linux works fine, but I cant get it to run on Windows...

[andrewfg]

do you know if installing with profile -Pgenerate-tag-classes should work with Windows?

As I recall it does work. But maybe it creates files with CRLF line endings rather than LF? In that case I use Visual Studio to do a manual search and replace.

[andrewfg]

pls rebase and re-run the generator?

@holgerfriedrich done!

[holgerfriedrich]

LGTM, thanks a lot!
Unfortunately it will take some time until we get this into the translated property files....